Skip to content

Commit 30448b9

Browse files
committed
fix: update
1 parent a3572d3 commit 30448b9

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

crates/node_binding/binding.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,8 @@ export interface JsHooks {
355355
finishMake: (compilation: JsCompilation) => void
356356
buildModule: (module: JsModule) => void
357357
chunkAsset: (asset: JsChunkAssetArgs) => void
358-
contextModuleFactoryBeforeResolve: (data: JsBeforeResolveArgs) => Promise<boolean | void>
359358
afterResolve: (data: AfterResolveData) => Promise<(boolean | void | AfterResolveCreateData)[]>
359+
contextModuleFactoryBeforeResolve: (data: JsBeforeResolveArgs) => Promise<boolean | void>
360360
contextModuleFactoryAfterResolve: (data: AfterResolveData) => Promise<boolean | void>
361361
normalModuleFactoryCreateModule: (data: CreateModuleData) => void
362362
normalModuleFactoryResolveForScheme: (data: JsResolveForSchemeInput) => Promise<JsResolveForSchemeResult>

crates/rspack_binding_values/src/hooks.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ use napi_derive::napi;
22
use rspack_napi::threadsafe_function::ThreadsafeFunction;
33

44
use crate::{
5-
AfterResolveCreateData, AfterResolveData, BeforeResolveData, CreateModuleData,
6-
JsAssetEmittedArgs, JsChunkAssetArgs, JsCompilation, JsExecuteModuleArg, JsModule,
5+
AfterResolveCreateData, AfterResolveData, CreateModuleData, JsAssetEmittedArgs,
6+
JsBeforeResolveArgs, JsChunkAssetArgs, JsCompilation, JsExecuteModuleArg, JsModule,
77
JsResolveForSchemeInput, JsResolveForSchemeResult, JsRuntimeModule, JsRuntimeModuleArg,
88
};
99

@@ -41,15 +41,13 @@ pub struct JsHooks {
4141
pub build_module: ThreadsafeFunction<JsModule, ()>, // TODO
4242
#[napi(ts_type = "(asset: JsChunkAssetArgs) => void")]
4343
pub chunk_asset: ThreadsafeFunction<JsChunkAssetArgs, ()>,
44-
#[napi(ts_type = "(data: JsBeforeResolveArgs) => Promise<boolean | void>")]
45-
pub context_module_factory_before_resolve: ThreadsafeFunction<JsBeforeResolveArgs, Option<bool>>,
4644
#[napi(
4745
ts_type = "(data: AfterResolveData) => Promise<(boolean | void | AfterResolveCreateData)[]>"
4846
)]
4947
pub after_resolve:
5048
ThreadsafeFunction<AfterResolveData, (Option<bool>, Option<AfterResolveCreateData>)>,
51-
#[napi(ts_type = "(data: BeforeResolveData) => Promise<boolean | void>")]
52-
pub context_module_factory_before_resolve: ThreadsafeFunction<BeforeResolveData, Option<bool>>,
49+
#[napi(ts_type = "(data: JsBeforeResolveArgs) => Promise<boolean | void>")]
50+
pub context_module_factory_before_resolve: ThreadsafeFunction<JsBeforeResolveArgs, Option<bool>>,
5351
#[napi(ts_type = "(data: AfterResolveData) => Promise<boolean | void>")]
5452
pub context_module_factory_after_resolve: ThreadsafeFunction<AfterResolveData, Option<bool>>,
5553
#[napi(ts_type = "(data: CreateModuleData) => void")]

crates/rspack_binding_values/src/normal_module_factory.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
use napi_derive::napi;
22
use rspack_core::{
3-
BeforeResolveArgs, NormalModuleAfterResolveArgs, NormalModuleCreateData, ResourceData,
3+
BeforeResolveArgs, NormalModuleAfterResolveArgs, NormalModuleAfterResolveCreateData,
4+
NormalModuleCreateData, ResourceData,
45
};
56

67
#[napi(object)]

crates/rspack_core/src/normal_module_factory.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ use crate::{
1717
FactorizeArgs, FactoryMeta, FuncUseCtx, GeneratorOptions, ModuleExt, ModuleFactory,
1818
ModuleFactoryCreateData, ModuleFactoryResult, ModuleIdentifier, ModuleRule, ModuleRuleEnforce,
1919
ModuleRuleUse, ModuleRuleUseLoader, ModuleType, NormalModule, NormalModuleAfterResolveArgs,
20-
NormalModuleCreateData, ParserOptions, RawModule, Resolve, ResolveArgs,
21-
ResolveOptionsWithDependencyType, ResolveResult, Resolver, ResolverFactory, ResourceData,
22-
ResourceParsedData, SharedPluginDriver,
20+
NormalModuleAfterResolveCreateData, NormalModuleCreateData, ParserOptions, RawModule, Resolve,
21+
ResolveArgs, ResolveOptionsWithDependencyType, ResolveResult, Resolver, ResolverFactory,
22+
ResourceData, ResourceParsedData, SharedPluginDriver,
2323
};
2424

2525
pub type NormalModuleFactoryBeforeResolveHook = AsyncSeriesBailHook<BeforeResolveArgs, bool>;

0 commit comments

Comments
 (0)