Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit 30c42ec

Browse files
committed
[wpt] Discard stderr when calling git
git occasionally prints warning messages to stderr (e.g. when too many files are modified and rename detection is disabled), which would mess with the output parsing if they are redirected to stdout. Fixes #18608.
1 parent 24b6c5f commit 30c42ec

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/wpt/testfiles.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def git(cmd, *args):
5151
full_cmd = [u"git", cmd] + list(item.decode("utf8") if isinstance(item, bytes) else item for item in args) # type: List[Text]
5252
try:
5353
logger.debug(" ".join(full_cmd))
54-
return subprocess.check_output(full_cmd, cwd=repo_path, stderr=subprocess.STDOUT).decode("utf8").strip()
54+
return subprocess.check_output(full_cmd, cwd=repo_path).decode("utf8").strip()
5555
except subprocess.CalledProcessError as e:
5656
logger.error("Git command exited with status %i" % e.returncode)
5757
logger.error(e.output)

0 commit comments

Comments
 (0)