Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit 88a0c99

Browse files
Juanmihdchromium-wpt-export-bot
authored andcommitted
Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky
Replacing the getElementById by the creation of a new element to ensure that the test will not be flaky. Changing also the name of the function to be coherent with the test itself. Bug: 978554 Change-Id: I8848b18f6d7f6201cce57069c5f4047d4d2f61e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693189 Commit-Queue: Juanmi Huertas <[email protected]> Reviewed-by: Fernando Serboncini <[email protected]> Cr-Commit-Position: refs/heads/master@{#677456}
1 parent 86b278e commit 88a0c99

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

imagebitmap-renderingcontext/tranferFromImageBitmap-ToBlob-offscreen.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
}
1616

1717
promise_test(function() {
18-
function testTransferFromImageBitmapNullability(greenImage) {
18+
function testTransferFromImageBitmapToBlobOffscreen(greenImage) {
1919
var bitmapCanvas = new OffscreenCanvas(width,height);
2020
var bitmapCtx = bitmapCanvas.getContext('bitmaprenderer');
2121
bitmapCtx.transferFromImageBitmap(greenImage);
2222

2323
// Make sure the bitmap renderer canvas is filled correctly.
24-
var pngImage = document.getElementById("img");
24+
var pngImage = new Image();
2525
bitmapCanvas.convertToBlob().then(function(blob){
2626
pngImage.src = URL.createObjectURL(blob);
2727
var myCanvasToTest = document.createElement('canvas');
@@ -43,7 +43,7 @@
4343
return Promise.all([
4444
createImageBitmap(greenCanvas),
4545
]).then(([greenImage]) => {
46-
testTransferFromImageBitmapNullability(greenImage);
46+
testTransferFromImageBitmapToBlobOffscreen(greenImage);
4747
});
4848
},'Test that transferToBlob works and produce the expected image');
4949

0 commit comments

Comments
 (0)