Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit a1105b5

Browse files
committed
[wpt] Correctly set the browser channel for Edge
This PR fixes two issues: 1. Add the "dev" channel for Edge (edgechromium). 2. When a channel is unrecognized for a browser, the channel is now correctly passed as is to wptrunner (as the log message says).
1 parent 049f9de commit a1105b5

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

tools/wpt/install.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
latest_channels = {
77
'firefox': 'nightly',
88
'chrome': 'dev',
9+
'edgechromium': 'dev',
910
'safari': 'preview',
1011
'servo': 'nightly'
1112
}
@@ -18,6 +19,7 @@
1819
'dev': latest_channels,
1920
'preview': latest_channels,
2021
'experimental': latest_channels,
22+
'canary': 'canary',
2123
}
2224

2325

tools/wpt/run.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,8 @@ def setup_wptrunner(venv, prompt=True, install_browser=False, **kwargs):
576576
kwargs["browser_channel"] = channel
577577
else:
578578
logger.info("Valid channels for %s not known; using argument unmodified" % kwargs["product"])
579-
del kwargs["channel"]
579+
kwargs["browser_channel"] = kwargs["channel"]
580+
del kwargs["channel"]
580581

581582
if install_browser:
582583
logger.info("Installing browser")

0 commit comments

Comments
 (0)