Skip to content

Commit abceae4

Browse files
committed
update tests and fix final ts errors
1 parent 0e41a7c commit abceae4

File tree

6 files changed

+20
-11
lines changed

6 files changed

+20
-11
lines changed

lib/interpolateName.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,17 @@ import type { LoaderContext } from "webpack";
22
import path from "path";
33
import getHashDigest from './getHashDigest';
44

5-
export default function interpolateName(loaderContext: LoaderContext<{}>, name: string, options = {}) {
5+
interface IInterpolateNameOptions {
6+
content?: Buffer;
7+
context?: string;
8+
regExp?: string;
9+
}
10+
11+
export default function interpolateName(loaderContext: LoaderContext<{}>, name: string | ((resourcePath: string, resourceQuery?: string) => string), options: IInterpolateNameOptions = {}) {
612
let filename;
713

8-
const hasQuery =
9-
loaderContext.resourceQuery && loaderContext.resourceQuery.length > 1;
14+
const hasQuery: boolean =
15+
(loaderContext.resourceQuery && loaderContext.resourceQuery.length > 1) as boolean;
1016

1117
if (typeof name === "function") {
1218
filename = name(
@@ -98,9 +104,12 @@ export default function interpolateName(loaderContext: LoaderContext<{}>, name:
98104
}
99105

100106
if (
107+
// @ts-ignore
101108
typeof loaderContext.options === "object" &&
109+
// @ts-ignore
102110
typeof loaderContext.options.customInterpolateName === "function"
103111
) {
112+
// @ts-ignore
104113
url = loaderContext.options.customInterpolateName.call(
105114
loaderContext,
106115
url,
@@ -110,4 +119,4 @@ export default function interpolateName(loaderContext: LoaderContext<{}>, name:
110119
}
111120

112121
return url;
113-
}
122+
}

lib/urlToRequest.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default function urlToRequest(url: string, root?: string | boolean): stri
2020
// 1. root is a string: root is prefixed to the url
2121
case "string":
2222
// special case: `~` roots convert to module request
23-
if (MODULE_REQUEST_REGEX.test(root)) {
23+
if (MODULE_REQUEST_REGEXP.test(root)) {
2424
request = root.replace(/([^~/])$/, "$1/") + url.slice(1);
2525
} else {
2626
request = root + url;
@@ -49,8 +49,8 @@ export default function urlToRequest(url: string, root?: string | boolean): stri
4949
}
5050

5151
// A `~` makes the url an module
52-
if (MODULE_REQUEST_REGEX.test(request)) {
53-
request = request.replace(MODULE_REQUEST_REGEX, "");
52+
if (MODULE_REQUEST_REGEXP.test(request)) {
53+
request = request.replace(MODULE_REQUEST_REGEXP, "");
5454
}
5555

5656
return request;

test/getHashDigest.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use strict";
22

3-
const loaderUtils = require("../");
3+
const loaderUtils = require("../dist");
44

55
describe("getHashDigest()", () => {
66
[

test/interpolateName.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use strict";
22

3-
const loaderUtils = require("../");
3+
const loaderUtils = require("../dist");
44

55
describe("interpolateName()", () => {
66
function run(tests) {

test/isUrlRequest.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use strict";
22

3-
const loaderUtils = require("../");
3+
const loaderUtils = require("../dist");
44

55
function ExpectedError(regex) {
66
this.regex = regex;

test/urlToRequest.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use strict";
22

3-
const loaderUtils = require("../");
3+
const loaderUtils = require("../dist");
44

55
function ExpectedError(regex) {
66
this.regex = regex;

0 commit comments

Comments
 (0)