CircleCI builds broken

[pderaaij]

Currently the builds in CircleCI are broken.

Unsure who is owning the project in CircleCI, but would be great if the following things could be checked.

• Environment variable COVERALLS_REPO_TOKEN configured in the CircleCI project
• If set, refresh the token via https://coveralls.io/refresh?private=true

Would be nice if the builds are working properly again.

Thanks in advance!

[pderaaij]

It is a bit weird that the builds triggered by dependabot are working properly.

[philsturgeon]

When I added docker pushing I had to disable env variables for forked repos, and I'm still trying to figure out how to enable coveralls without leaking secrets.

[pderaaij]

Tricky one, did some research but didn't found that much useful. Will have another look when I have more time.

[pderaaij]

Have been looking into the setup of https://github.com/facebook/react which also uses CircleCI and coveralls. In that repo they only upload the coverage on the master branch, so after merges of the PR. Which seems to be also be the best way to approach this.

If we want it like that we would have to add a conditional to only update the coverage report on the master branch. Just like they've done in the post with the early return on forked PRs:
https://circleci.com/blog/managing-secrets-when-you-have-pull-requests-from-outside-contributors/