Remove lock statements from InAppNotification control
#3368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
|
Sweet. Indeed, Anyway, I am not able to test that for the moment but the code seems OK. |
|
@vgromfeld seems like there is a conflict being detected. If you can resolve the conflict then it should do the Job 🚀 |
Microsoft.Toolkit.Uwp.UI.Controls/InAppNotification/Styles/MSEdgeNotificationStyle.xaml
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls/InAppNotification/InAppNotification.cs
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/InAppNotification/InAppNotificationPage.xaml.cs
Show resolved
Hide resolved
michael-hawker
approved these changes
Jul 21, 2020
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
1 task
ghost
merged commit
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Remove the
lockstatements used inInAppNotificationas well as all the timers used to detect when the animation ends.PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current
InAppNotificationimplementation is using a lot oflockwhich are not needed since all the code lives in the UI thread.What is the new behavior?
The control is no longer using any
lock. All the notifications are now pushed to_stackedNotificationOptionswhich will control when the notification is displayed. This change allow us to set the appropriate content on theContentPresenterwhen the control template is applied.WE can also now push directly an
objectcontent as the notification payload. To make it always work, I've simplified the logic between theInAppNotificationand its template. This is introducing a breaking change in the notification template.PR Checklist
Please check if your PR fulfills the following requirements:
The
ContentPresenterof theInAppNotificationtemplate must now be namedPART_Presenter.Other information
The XAML files have been updated by XAML styler and contains a lot of changes unrelated to this PR.