-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Enable light templating in InAppNotification #3371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable light templating in InAppNotification #3371
Conversation
Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍. I've just one suggestion that I left in a comment.
Microsoft.Toolkit.Uwp.UI.Controls/InAppNotification/Styles/MSEdgeNotificationStyle.xaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
…ub.com/vgromfeld/WindowsCommunityToolkit into inAppNotification.allowLightTemplating
@vgromfeld can you resolve the merge conflict here? Be careful too as #3375 also has conflicts, so not sure if incompatible. |
Adjusting some style properties of
InAppNotification
like the margin between the dismiss button and the content requires a full retemplate. We can avoid this by using named resources and allow a "light" templating by adjusting only the resources we want.PR Type
What kind of change does this PR introduce?
What is the current behavior?
The default style of
InAppNotification
contains fixed values that are not easily customizable like the margin for the dismiss button:What is the new behavior?
InAppNotification
default style will now use named resources for some key layout properties.This will allow us to only redefine those property to adjust the layout instead of going through a full retemplate.
We will now be able to customize the following properties:
PR Checklist
Please check if your PR fulfills the following requirements: