Skip to content

Correct default AutomationProperties.Name for GridSplitter #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

paulcam206
Copy link
Contributor

@paulcam206 paulcam206 commented Jun 30, 2020

Fixes #3372

Minor typo in GridSplitter's default AutomationProperties.Name

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

defaults to GridSpliter

What is the new behavior?

defaults to GridSplitter

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jun 30, 2020

Thanks paulcam206 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker michael-hawker added this to the 7.0 milestone Jun 30, 2020
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@paulcam206
Copy link
Contributor Author

:shipit:

@azchohfi azchohfi merged commit 8756f29 into CommunityToolkit:master Jul 10, 2020
@ghost ghost added the Completed 🔥 label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default accessibility name for GridSplitter misspelled
5 participants