Improved reliability of Task.GetResultOrDefault #3410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #3229
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
Task.GetResultOrDefault
can returnnull
on some runtimes, if the inputTask
(Task<T>
) instance is actually a subclass.Eg. on UWP that type is sometimes some internal
AsyncValueBox<T>
type, which fails with that method (it returnsnull
).What is the new behavior?
The extension is now more reliable and works with
Task<T>
-inherited type.PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates