Skip to content

Massive amount of spelling fixes #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
11 commits merged into from
Aug 24, 2020
Merged

Massive amount of spelling fixes #3434

11 commits merged into from
Aug 24, 2020

Conversation

HerrickSpencer
Copy link
Contributor

Fixes

After the last PR for minor spelling issues, I ran a spelling check on the rest of the code and found many places to fix typos. I am looking into a way to automate this into the PR checks, but this will take some effort due to needing many items added to the 'ignore' list.

PR Type

What kind of change does this PR introduce?

  • Documentation content changes
  • Sample app changes

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 14, 2020

Thanks HerrickSpencer for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost August 14, 2020 16:16
@HerrickSpencer HerrickSpencer marked this pull request as ready for review August 17, 2020 17:28
@HerrickSpencer
Copy link
Contributor Author

There are a lot of places where a hyphen probably should be included... 'multi-line' or 'sub-channel' but I've skipped them for now.

Kyaa-dost
Kyaa-dost approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HerrickSpencer !! This is ready to 🚀 🚀

@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Aug 17, 2020
Sergio0694
Sergio0694 requested changes Aug 18, 2020
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Just left a couple small notes and questions, but wow that's a lot of fixed typos! 😄

azchohfi
azchohfi requested changes Aug 18, 2020
View reviewed changes
@michael-hawker michael-hawker mentioned this pull request Aug 18, 2020
Open
@HerrickSpencer @Sergio0694
Revert spelling 'fix' in Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/C…
95be099 
…ollectionViews/CollectionView.cs


the word uncancelable is ok (though all spelling checkers flag it)

Co-authored-by: Sergio Pedri <[email protected]>
@ghost
Copy link

ghost commented Aug 20, 2020

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

HerrickSpencer and others added 3 commits August 20, 2020 16:05
@HerrickSpencer @Sergio0694
Fix minor spacing issue in Microsoft.Toolkit.Uwp.UI.Controls/WrapPane…
c9f8210 
…l/WrapPanel.cs


add a space for clarity in comment

Co-authored-by: Sergio Pedri <[email protected]>
@HerrickSpencer @azchohfi @Sergio0694
Apply suggestions from code review
ea41c89 
Co-authored-by: Alexandre Zollinger Chohfi <[email protected]>
Co-authored-by: Sergio Pedri <[email protected]>
@HerrickSpencer
Update per review comment
0b57e66
@HerrickSpencer
Copy link
Contributor Author

updated code per comments. Mostly accepted all changes.

@Kyaa-dost
Copy link
Contributor

Thanks, @HerrickSpencer!! Looks great 😊

@ghost ghost removed the needs attention 👋 label Aug 24, 2020
Sergio0694
Sergio0694 requested changes Aug 24, 2020
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just found one last super tiny nit 😄

Sergio0694
Sergio0694 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, fixed it myself to save time 😄

Looks great, thanks @HerrickSpencer! 🚀🚀🚀

@ghost
Copy link

ghost commented Aug 24, 2020

Hello @Sergio0694!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 596fdfc into master Aug 24, 2020
@ghost ghost deleted the moreSpelling branch August 24, 2020 16:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azchohfi azchohfi azchohfi approved these changes

@Sergio0694 Sergio0694 Sergio0694 approved these changes

@Kyaa-dost Kyaa-dost Kyaa-dost approved these changes

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

Assignees
No one assigned
Labels
auto merge ⚡ documentation 📃
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HerrickSpencer @Kyaa-dost @azchohfi @Sergio0694 @michael-hawker