Fixed thread safety for NetworkHelper.Instance #3490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
bug 🐛
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
vgromfeld
approved these changes
Sep 22, 2020
Rosuavio
approved these changes
Nov 6, 2020
|
Thanks @Sergio0694! Nice catch on picking up the issue. I had forgotten about it. Did you do a quick scan for any other cases we might have missed? |
michael-hawker
approved these changes
Nov 6, 2020
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@michael-hawker I did and it seemed like the other types had already been fixed with the new pattern, but I can take another look tomorrow across the whole package to see if I can spot any leftovers! 😄 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3197
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
NetworkHelper.Instanceproperty is not thread-safe.What is the new behavior?
The
NetworkHelper.Instanceproperty is now thread safe and initialized in the implicit static constructor.PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates