Skip to content

Fix GitHub icon positioning #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Fix GitHub icon positioning #3508

merged 2 commits into from
Sep 28, 2020

Conversation

marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Sep 28, 2020

Fixes #3501

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The GitHub icon is not positioned correctly

image

What is the new behavior?

GitHub icon is centered

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • [N/A] Tested code with current supported SDKs
  • [N/A] Pull Request has been submitted to the documentation repository instructions. Link:
  • [N/A] Sample in sample app has been added / updated (for bug fixes / features)
  • [N/A] Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [N/A] Header has been added to all new source files (run build/UpdateHeaders.bat)
  • [N/A] Contains NO breaking changes

Other information

I have know idea what the issue with the SVG is

@ghost
Copy link

ghost commented Sep 28, 2020

Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost September 28, 2020 18:17
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼 labels Sep 28, 2020
@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Sep 28, 2020
@Kyaa-dost
Copy link
Contributor

@chingucoding CI is failing due to the formatting but other than that looks great 🚀 🚀

image


@marcelwgn
Copy link
Contributor Author

CI passed now, the error message wasn't helpful though. How did you know it was a formatting issue causing the test failure @Kyaa-dost ?

@Kyaa-dost
Copy link
Contributor

@chingucoding Thanks looks good now. It was mentioned in the logs when Toolkit/CI runs the test. I don't think you have access to that but we can check the results in our end for the verification.

@marcelwgn
Copy link
Contributor Author

Oh I see, thanks.

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @chingucoding!

Yeah that CI error is the same one I saw in another PR I had, not sure what caused it but it seems to have been fixed already in a past commit anyway (passing fine now and in master too), so all good! 🎉

@Sergio0694 Sergio0694 merged commit 79127cf into CommunityToolkit:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SampleApp] GitHub icon not centered
3 participants