-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New [ReadOnly]Memory<T>.Cast<TFrom, TTo> extensions #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
michael-hawker
approved these changes
Nov 12, 2020
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Rosuavio
approved these changes
Nov 12, 2020
7 tasks
ghost
pushed a commit
that referenced
this pull request
Dec 8, 2020
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 --> <!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork. This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 --> ## Follow up from #3520 <!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. --> <!-- Add a brief overview here of the feature/bug & fix. --> ## PR Type What kind of change does this PR introduce? <!-- Please uncomment one or more that apply to this PR. --> - Optimization <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> The codegen for the second branch in `RuntimeHelpers.ConvertLength` does a signed division: https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/9b75c9f910f999834c64bd00e522d7ae464c121b/Microsoft.Toolkit.HighPerformance/Helpers/Internals/RuntimeHelpers.cs#L43-L46 This is not the best for the codegen, as the JIT has to handle the sign in that division, resulting in the following: ```asm ; [System.Byte, System.Private.CoreLib],[System.Numerics.Vector4, System.Numerics.Vectors] ConvertLength[TFrom, TTo](Int32) L0000: mov eax, ecx L0002: sar eax, 0x1f L0005: and eax, 0xf L0008: add eax, ecx L000a: sar eax, 4 L000d: ret ``` ## What is the new behavior? <!-- Describe how was this issue resolved or changed? --> Avoided that with a cast to `uint`, since the length is guaranteed to be a positive value in `[0, int.MaxValue]` anyway: ```asm ; [System.Byte, System.Private.CoreLib],[System.Numerics.Vector4, System.Numerics.Vectors] L0000: mov eax, ecx L0002: shr eax, 4 L0005: ret ``` Perfect! 😄🎉 ## PR Checklist Please check if your PR fulfills the following requirements: - [X] Tested code with current [supported SDKs](../readme.md#supported) - [ ] ~~Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->~~ - [ ] ~~Sample in sample app has been added / updated (for bug fixes / features)~~ - [ ] ~~Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)~~ - [X] Tests for the changes have been added (for bug fixes / features) (if applicable) - [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*) - [X] Contains **NO** breaking changes
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merge ⚡
feature 💡
high-performance 🚂
Issues/PRs for the Microsoft.Toolkit.HighPerformance package
.NET
Components which are .NET based (non UWP specific)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Right now there is no (easy) way to cast a
Memory<TFrom>
instance to aMemory<TTo>
instance. There are APIs to to do that forSpan<T>
instances, but not forMemory<T>
. The reason for that is that with aSpan<T>
it's just a matter of retrieving the wrapped reference, reinterpreting it and then adjusting the size, then creating a newSpan<T>
instance. But aMemory<T>
instance is completely different: it wraps an object which could be either aT[]
array, aMemoryManager<T>
instance, etc. The result is that currently there are no APIs in the BCL nor in the toolkit to just "cast" aMemory<T>
.This feature has been requested by a number of developers, including in a well known library such as
ImageSharp
:(
ImageSharp
issue, here)To solve that, I created a very simplified version of the code included in this PR, into a PR here.
Having this available right out of the box in the
HighPerformance
package would be helpful in a number of similar situations, especially withMemory<T>
APIs becoming more and more common across libraries now (as they've been out for a while).What is the new behavior?
This PR includes 4 new extensions for the
Memory<T>
andReadOnlyMemory<T>
types that enable the following:Here is the full list of the new APIs introduced in this PR:
Notes
Marking as draft as this is still being worked on, but feedbacks and reviews are welcome! 😄
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates