Skip to content

Update Template Instructions #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6 commits merged into from
Oct 20, 2020
Merged

Update Template Instructions #3531

6 commits merged into from
Oct 20, 2020

Conversation

Kyaa-dost
Copy link
Contributor

Fixes

An update to the Template.

PR Type

What kind of change does this PR introduce?

Documentation content changes

What is the current behavior?

Lack of instructions on Template requirements

What is the new behavior?

Highlight the importance of template instructions.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Oct 16, 2020

Thanks Kyaa-dost for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi October 16, 2020 22:01
@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Oct 19, 2020
@Kyaa-dost Kyaa-dost marked this pull request as ready for review October 19, 2020 16:24
@ghost
Copy link

ghost commented Oct 19, 2020

Hello @Kyaa-dost!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, it pops a lot more. I ❤️ Emojis.

@ghost ghost merged commit 6d567c5 into master Oct 20, 2020
@ghost ghost deleted the Kyaa-UpdateTemplate branch October 20, 2020 17:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants