-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Win32 scheduled notification and Setting fixes #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Hey @michael-hawker, this bug fix (plus some more sample app code) is ready for review whenever you get a chance! |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msftbot merge if @azchohfi approves. |
Hello @michael-hawker! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
@azchohfi this is ready to be reviewed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewleader Nice work on the PR. Changes in the sample app looking great 🚀🚀
@msftbot only merge this PR when approved by @azchohfi |
Hello @Kyaa-dost! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Fixes #3626
Identity-less Win32 apps had the following problems...
Setting
property threw an exceptionTo fix each of these (all fixes specific only to identity-less Win32 apps)...
AddToSchedule
orSetting
is called, first checks if has sent a toast before, and if not sends a silent toast and then immediately removes it, so that scheduled toasts and accessing setting value "just work" to the developerThis required introducing
ToastNotifierCompat
(in order to intercept the Show/AddToSchedule API calls). It's merely a copy of ToastNotifier just so that we can add in additional code before/after some specific methods are called.Additionally, added a code sample to the Win32 sample app for using progress bar within toasts!
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See above
What is the new behavior?
See above
PR Checklist
Please check if your PR fulfills the following requirements:
Note that this is NOT a breaking change... while we've changed
ToastNotificationManagerCompat.CreateToastNotifier()
's return type,ToastNotificationManagerCompat
is only in the 7.0 preview right now (and the first version with that class was only introduced 4 days ago).Other information