Skip to content

Add extensions support for CompositionConditionalValue #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arcadiogarcia
Copy link
Member

@arcadiogarcia arcadiogarcia commented Dec 4, 2020

Fixes

Currently the toolkit has helpers for creating expression animations for InteractionTrackerInertiaRestingValue, InteractionTrackerInertiaMotion... but there are no equivalent extension methods for working with the similar CompositionConditionalValue (which is used to configure CenterPoint modifiers for InteractionTrackers/VisualInteractionSources). This PR adds the same extension methods that already exist for the former types to the latter.

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

There are no extension methods for working with CompositionConditionalValue

What is the new behavior?

The same extensions that are available for other modifiers are now available for CompositionConditionalValue

PR Checklis

Please check if your PR fulfills the following requirements:

Other information

@ghost
Copy link

ghost commented Dec 4, 2020

Thanks arcadiogarcia for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@arcadiogarcia arcadiogarcia marked this pull request as ready for review December 4, 2020 21:07
@michael-hawker michael-hawker added this to the 7.0 milestone Dec 8, 2020
@ghost ghost added the in progress 🚧 label Dec 8, 2020
@michael-hawker
Copy link
Member

Thanks @arcadiogarcia, seems straight-forward enough. I haven't explored this API set much in the toolkit. Mind if I pick your brain a bit?

I don't think there's any unit tests for this API. Is this something you think we could try and test to some degree? Any thoughts?

We're also working towards trying to tease out the dependencies on Behaviors and Win2D which are both tied to this package. As a consumer of this package, any thoughts on how we might split some of these bits apart to other parts of the Toolkit?

Thanks!

@ghost
Copy link

ghost commented Dec 8, 2020

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1ad70b4 into CommunityToolkit:master Dec 8, 2020
@arcadiogarcia
Copy link
Member Author

@michael-hawker Testing that the animation works as expected might be tricky, but I think having a few unit tests for CreateExpressionAnimationFromNode would be a great idea, if only to make sure we exercise all the operators and catch regressions in the ones that are used less often (like the recent bug affecting !).

I don't think i have any strong opinions regarding how the packages are split because I personally rarely only use this package, I usually need the whole Controls package (and automatically get Animations as a dependency, otherwise I'd reference it separately).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants