Type property is now optional for Samples #3648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to more easily create XAML Only samples and load them more efficiently. Removed Dummy Pages for State Triggers as a Test
ghost
added
the
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker
added a commit
to CommunityToolkit/WindowsCommunityToolkit-wiki
that referenced
this pull request
Dec 31, 2020
Related to changes from CommunityToolkit/WindowsCommunityToolkit#3648
|
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 43 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
2 tasks
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to more easily create XAML Only samples and load them more efficiently.
Removed Dummy Pages for State Triggers as a Test
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All samples are required to have a Page within the project, even if it's not used.
What is the new behavior?
Consolidated any compiler needs within the
XamlOnlyPage.xamlpage, and made theTypeproperty optional onSample. We'll now load a.bindfile directly in theSampleControllerif the sample doesn't have a backing page but still has a template.This makes it easier to create samples that don't need extra features related to having a page (reacting to rendering, creating buttons, or having auxiliary content around the sample).
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Updated Wiki with new Guidance here: CommunityToolkit/WindowsCommunityToolkit-wiki#17