Skip to content

fix: Invalid InAppNotification.KeyFrameDuration default value data type #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jan 6, 2021

Conversation

jeromelaban
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

InAppNotification.KeyFrameDuration dependency property data type is now the same as the dependency property type.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jan 5, 2021

Thanks jeromelaban for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost January 5, 2021 15:51
@jeromelaban jeromelaban changed the title fix: Invalid KeyFrameDuration default value data type fix: Invalid InAppNotification.KeyFrameDuration default value data type Jan 5, 2021
@ghost ghost requested a review from Rosuavio January 5, 2021 15:51
@michael-hawker michael-hawker added this to the 7.0 milestone Jan 6, 2021
@michael-hawker michael-hawker added auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ maintenance ⚙️ labels Jan 6, 2021
@ghost ghost added the in progress 🚧 label Jan 6, 2021
@ghost
Copy link

ghost commented Jan 6, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member

Thanks @jeromelaban! Nice catch! It's amazing how easy it is to mess these things up sometimes when writing Dependency Properties.

@ghost ghost merged commit 789d061 into CommunityToolkit:master Jan 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants