Skip to content

Fix SmokeTest Projects to Use Version from CI #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jan 6, 2021

Conversation

michael-hawker
Copy link
Member

Fixes #3657

Adjusts SmokeTest project and Cake script to pass in the Version of the Toolkit being built to ensure NuGet restores the proper version when building the SmokeTest projects (and used for analysis later).

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

SmokeTests will grab latest from NuGet

What is the new behavior?

SmokeTests will grab version from CI

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior maintenance ⚙️ build 🔥 CI/pipeline 🔬 labels Jan 6, 2021
@michael-hawker michael-hawker added this to the 7.0 milestone Jan 6, 2021
@ghost ghost added the in progress 🚧 label Jan 6, 2021
@ghost
Copy link

ghost commented Jan 6, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi, Kyaa-dost and Rosuavio January 6, 2021 11:13
@ghost ghost added the nuget 📦 label Jan 6, 2021
@michael-hawker
Copy link
Member Author

Yay! Finally! 🎉🎉🎉

@azchohfi this look good to you?

@ghost
Copy link

ghost commented Jan 6, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 5 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member Author

@RosarioPulella want to take a quick look? Then we can update the dev-animations branch to help double-check the new animation packages in @Sergio0694's PR too.

@ghost ghost merged commit 9bee239 into CommunityToolkit:master Jan 6, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build/CI] Smoke Tests don't run from current build
3 participants