-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Reorg layout #3714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg layout #3714
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Ah, you forgot to split the |
pull in Uwp.UI
@RosarioPulella looks like removing the primitives was only a 5kb difference in our practical test, so pretty minimal without any of the XAML components. For now though still good to try and keep things isolated, but good to know for the future if we build more complex controls that if we have XAML-less ones they're easy to reference without much ramification. I think the main thing we're just starting to learn some of these general patterns about what makes things bad or worse. Once we get shipping, we can investigate how we can store our baseline numbers and have PRs compare against that for us to detect any large swings before they get integrated. I was thinking we could just have a dedicated repo for that which could be easy to have the CI commit updates to when something is merged to main. It's interesting that overall we only saw about a 400kb decrease to the core package by pulling out the Layout controls. I'm curious how the Input package next will fair. |
@RosarioPulella this seems like a good change, I think this would be ready to merge into the dev branch, eh? Any concerns or other things we should check? |
|
Almost forgot to split out the DesignTools project for the layout controls. |
@@ -193,18 +193,6 @@ | |||
<value>Warning</value> | |||
<comment>Label for TextToolbar Control Warning message.</comment> | |||
</data> | |||
<data name="WCT_BladeView_ExpandButton_Collapsed" xml:space="preserve"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to update the strings, see f3547fe, not sure if you want to cherry-pick or just have that forward-fixed?
Just cheery picked, should be ready now. |
Thanks @RosarioPulella, I'll merge this once the CI passes and then we can close out the Input PR next. 🎉 |
Step towards #3594
Reorganize some of the layout controls.
Moved the code in
Controls.Layout
intoControls.Primitives
.Moved
LayoutTransformControl
,HeaderedContentControl
,HeaderedItemsControl
,ListDetailsView
,Carousel
,OrbitView
,BladeView
,Expander
,GridSplitter
intoControls.Layout
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information