Skip to content

Reorg layout #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 4, 2021
Merged

Reorg layout #3714

merged 13 commits into from
Feb 4, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Feb 1, 2021

Step towards #3594

Reorganize some of the layout controls.

Moved the code in Controls.Layout into Controls.Primitives.
Moved LayoutTransformControl, HeaderedContentControl, HeaderedItemsControl, ListDetailsView, Carousel, OrbitView, BladeView, Expander, GridSplitter into Controls.Layout

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Feb 1, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost February 1, 2021 22:12
@michael-hawker
Copy link
Member

michael-hawker commented Feb 1, 2021

@RosarioPulella couple of test failures, assume string resource lookup related:

image

image

Taking a quick look...

@michael-hawker
Copy link
Member

Ah, you forgot to split the Generic.xaml file into the Layout package, checking if that's fixing the tests locally.

@michael-hawker
Copy link
Member

@RosarioPulella looks like removing the primitives was only a 5kb difference in our practical test, so pretty minimal without any of the XAML components. For now though still good to try and keep things isolated, but good to know for the future if we build more complex controls that if we have XAML-less ones they're easy to reference without much ramification.

I think the main thing we're just starting to learn some of these general patterns about what makes things bad or worse. Once we get shipping, we can investigate how we can store our baseline numbers and have PRs compare against that for us to detect any large swings before they get integrated. I was thinking we could just have a dedicated repo for that which could be easy to have the CI commit updates to when something is merged to main.

It's interesting that overall we only saw about a 400kb decrease to the core package by pulling out the Layout controls. I'm curious how the Input package next will fair.

@Rosuavio Rosuavio changed the title Reorg layout [WIP] Reorg layout Feb 3, 2021
@michael-hawker
Copy link
Member

@RosarioPulella this seems like a good change, I think this would be ready to merge into the dev branch, eh? Any concerns or other things we should check?

@Rosuavio
Copy link
Contributor Author

Rosuavio commented Feb 3, 2021

It should be ready now, doing some last checks but I'll take it out of draft. Ready @michael-hawker

@Rosuavio Rosuavio changed the title [WIP] Reorg layout Reorg layout Feb 3, 2021
@Rosuavio Rosuavio marked this pull request as ready for review February 3, 2021 21:21
@Rosuavio Rosuavio added controls 🎛️ for-review 📖 To evaluate and validate the Issues or PR reviewers wanted ✋ and removed in progress 🚧 labels Feb 3, 2021
@Rosuavio
Copy link
Contributor Author

Rosuavio commented Feb 3, 2021

Almost forgot to split out the DesignTools project for the layout controls.

@@ -193,18 +193,6 @@
<value>Warning</value>
<comment>Label for TextToolbar Control Warning message.</comment>
</data>
<data name="WCT_BladeView_ExpandButton_Collapsed" xml:space="preserve">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to update the strings, see f3547fe, not sure if you want to cherry-pick or just have that forward-fixed?

@Rosuavio
Copy link
Contributor Author

Rosuavio commented Feb 4, 2021

Just cheery picked, should be ready now.

@michael-hawker
Copy link
Member

Thanks @RosarioPulella, I'll merge this once the CI passes and then we can close out the Input PR next. 🎉

@michael-hawker michael-hawker merged commit 7463d9f into CommunityToolkit:dev/split-controls Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls 🎛️ for-review 📖 To evaluate and validate the Issues or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants