Skip to content

Add another Baseline for understanding WinUI overhead. #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michael-hawker
Copy link
Member

What is the current behavior?

Baseline is a pure UWP

What is the new behavior?

Add another Baseline to see effects of adding WinUI (and using NavigationView from it).

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Feb 2, 2021

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from azchohfi, Kyaa-dost and Rosuavio February 2, 2021 20:37
@michael-hawker michael-hawker marked this pull request as ready for review February 3, 2021 00:10
@michael-hawker
Copy link
Member Author

Looks like WinUI 2.x adds about a meg of overhead in the UWP .NET Native dll size, that that doesn't seem to fluctuate much once after from other tests I've seen us doing.

@Rosuavio
Copy link
Contributor

Rosuavio commented Feb 3, 2021

Do we still want to merge this test?

@michael-hawker michael-hawker added this to the 7.0 milestone Feb 4, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

TODO: Should have projects be smarter in analysis about which baseline to compare against?
@michael-hawker michael-hawker merged commit 4a3f9ee into CommunityToolkit:master Mar 1, 2021
@michael-hawker michael-hawker deleted the smoketest-winui branch March 1, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants