Skip to content

Remove services and related #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Remove services and related #3757

merged 1 commit into from
Feb 17, 2021

Conversation

Rosuavio
Copy link
Contributor

Fixes

Remove the Microsoft.Toolkit.Services Project and the related sample and smoke test code.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Sample app changes

What is the current behavior?

The project builds and publishs the Microsoft.Toolkit.Services package and has related samples in the sample app.

What is the new behavior?

The project does not build and publish the Microsoft.Toolkit.Services package and the related samples are not in the sample app.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Feb 16, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost February 16, 2021 16:11
@michael-hawker michael-hawker marked this pull request as ready for review February 16, 2021 17:28
@michael-hawker michael-hawker added services 👷‍♂️ next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. labels Feb 16, 2021
@ghost ghost added the in progress 🚧 label Feb 16, 2021
@ghost ghost added this to the 7.0 milestone Feb 16, 2021
@Rosuavio Rosuavio added auto merge ⚡ for-review 📖 To evaluate and validate the Issues or PR and removed in progress 🚧 labels Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member

@RosarioPulella I'm going to merge this to keep us going. We should think about where we want to put the Graph in the Sample App vs. it being the only thing in the Services category. We'll clean that up after we get the preview out. Thanks!

@michael-hawker michael-hawker merged commit 3b36a59 into CommunityToolkit:master Feb 17, 2021
@ghost ghost added the Completed 🔥 label Feb 17, 2021
@Rosuavio Rosuavio deleted the remove-services branch February 17, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ Completed 🔥 for-review 📖 To evaluate and validate the Issues or PR introduce breaking changes 💥 next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. services 👷‍♂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants