Update license and icon based on @kyaa-dost's investigation #3777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker
added
build 🔥
next preview ✈️
8 tasks
Based on @Kyaa-dost's initial investigation Keeping old and new formats as not all clients support the new formats in all scenarios yet.
michael-hawker
force-pushed
the
nuget-update
branch
from
db233c4 to
83984d5
Compare
|
Looks good from NuGet Package Explorer:
Saw that VS doesn't support the license display properly yet, so thinking we should keep both properties. Going to try and add that back. Added comment here: NuGet/Home#8000 (comment) |
Rosuavio
approved these changes
Feb 23, 2021
Keep embedded license file though as well.
michael-hawker
commented
Feb 23, 2021
Microsoft.Toolkit.Uwp.Notifications/Microsoft.Toolkit.Uwp.Notifications.nuspec
Outdated
Show resolved
Hide resolved
|
Hit #3775 issue again, merged main to see if we can get a good build again. |
|
Alright, I think this gets us to be good enough with compliance:
|
|
@azchohfi you good with this? |
|
Ugh.... I don't mind, but its weird to embed the file and not use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to replace #3765
Fixes the nuget license/icon file based on #3765, single commit.