Add ContentPresenter to Logical Tree helpers #3811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps get down through SwitchPresenter. (Up doesn't work as Parent is not being set, WinUI bug?)
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
|
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sergio0694
approved these changes
Mar 8, 2021
Microsoft.Toolkit.Uwp.UI/Extensions/FrameworkElement/FrameworkElementExtensions.LogicalTree.cs
Outdated
Show resolved
Hide resolved
Rosuavio
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes N/A
As I was writing the SwitchPresenter docs, I was doing some tests about how it loads/doesn't load content into the VisualTree. I noticed the VisualTree could find the descendants, but our logical helpers could not.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Can't find the loaded children in the Logical Tree.
What is the new behavior?
If ContentPresenter (like SwitchPresenter) have content which are also Framework Elements (and not data) then we'll continue walking like we would with a ContentControl.
This is important as some templates for controls use ContentPresenter more often than ContentControl in other places as ContentPresenter is lighter-weight than ContentControl.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information