StringExtensions: Switch to italic instead of blue, fix bug with bold effect not being applied

[marcelwgn]

Fixes

Fixes #3815

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

[ghost]

Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[Kyaa-dost]

@chingucoding Thanks for the PR ❤️ Seems like there might be a bug that already exists in the current version where the String does not seem to be highlighted as bold when enabled. Do you know what would be causing this?

[marcelwgn]

@Kyaa-dost this issue seems to have existed before, should I include the fix for this in this PR? Also how can "IsValidString" return false on a text only control?

[michael-hawker]

@chingucoding up to you, I'm fine just merging as is for now to close out the original issue.

[marcelwgn]

If it's fine with you, I can fix it in this PR. If you want a separate PR, that works for me too, you decide @michael-hawker.

[Kyaa-dost]

@chingucoding correct, that issue already exists whereas your PR solves the problem of #3815. If it's a quick fix for you then please proceed to merge through this PR, and if not then we can fix this at a different time.

[marcelwgn]

Fixed now @michael-hawker and @Kyaa-dost !

[Kyaa-dost]

@chingucoding still seeing this. Are you not able to repro?

[marcelwgn]

@Kyaa-dost Works fine on my machine™:

[Rosuavio]

It also works on my machine.

[Kyaa-dost]

@chingucoding just rebuilt and looks good now. Thanks for all the effort!

[marcelwgn]

Awesome! Happy to help! Is there anything stopping a merge then?

[michael-hawker]

@chingucoding nope, just going to be merging other PRs in first that we want to validate builds on as then it's harder to merge them. This one is easier to merge after as I know I won't have to wait for the CI or care about it stopping.

I'll get this merged in later this afternoon. Thanks for all the help! 🦙❤