-
Notifications
You must be signed in to change notification settings - Fork 1.4k
StringExtensions: Switch to italic instead of blue, fix bug with bold effect not being applied #3820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StringExtensions: Switch to italic instead of blue, fix bug with bold effect not being applied #3820
Conversation
Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chingucoding Thanks for the PR ❤️ Seems like there might be a bug that already exists in the current version where the String does not seem to be highlighted as bold when enabled. Do you know what would be causing this?
@Kyaa-dost this issue seems to have existed before, should I include the fix for this in this PR? Also how can "IsValidString" return false on a text only control? |
@chingucoding up to you, I'm fine just merging as is for now to close out the original issue. |
If it's fine with you, I can fix it in this PR. If you want a separate PR, that works for me too, you decide @michael-hawker. |
@chingucoding correct, that issue already exists whereas your PR solves the problem of #3815. If it's a quick fix for you then please proceed to merge through this PR, and if not then we can fix this at a different time. |
Fixed now @michael-hawker and @Kyaa-dost ! |
@chingucoding still seeing this. Are you not able to repro? |
@Kyaa-dost Works fine on my machine™: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chingucoding just rebuilt and looks good now. Thanks for all the effort!
Awesome! Happy to help! Is there anything stopping a merge then? |
@chingucoding nope, just going to be merging other PRs in first that we want to validate builds on as then it's harder to merge them. This one is easier to merge after as I know I won't have to wait for the CI or care about it stopping. I'll get this merged in later this afternoon. Thanks for all the help! 🦙❤ |
Fixes
Fixes #3815
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information