Skip to content

StringExtensions: Switch to italic instead of blue, fix bug with bold effect not being applied #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcelwgn
Copy link
Contributor

Fixes

Fixes #3815

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

Screenshot of app showing different indicators of properties being false

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 8, 2021

Thanks chingucoding for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi, Kyaa-dost and Rosuavio March 8, 2021 18:23
@ghost ghost added accessibility ♿ bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼 labels Mar 8, 2021
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chingucoding Thanks for the PR ❤️ Seems like there might be a bug that already exists in the current version where the String does not seem to be highlighted as bold when enabled. Do you know what would be causing this?

image

@michael-hawker michael-hawker added this to the 7.0 milestone Mar 8, 2021
@marcelwgn
Copy link
Contributor Author

@Kyaa-dost this issue seems to have existed before, should I include the fix for this in this PR? Also how can "IsValidString" return false on a text only control?

@michael-hawker
Copy link
Member

@chingucoding up to you, I'm fine just merging as is for now to close out the original issue.

@marcelwgn
Copy link
Contributor Author

If it's fine with you, I can fix it in this PR. If you want a separate PR, that works for me too, you decide @michael-hawker.

@Kyaa-dost
Copy link
Contributor

@chingucoding correct, that issue already exists whereas your PR solves the problem of #3815. If it's a quick fix for you then please proceed to merge through this PR, and if not then we can fix this at a different time.

@marcelwgn marcelwgn changed the title StringExtensions: Switch to italic instead of blue StringExtensions: Switch to italic instead of blue, fix bug with bold effect not being applied Mar 8, 2021
@marcelwgn
Copy link
Contributor Author

Fixed now @michael-hawker and @Kyaa-dost !

@Kyaa-dost
Copy link
Contributor

Kyaa-dost commented Mar 8, 2021

@chingucoding still seeing this. Are you not able to repro?

image

@marcelwgn
Copy link
Contributor Author

@Kyaa-dost Works fine on my machine™:

Image showing text being highlighted using italic and bold font

@Rosuavio
Copy link
Contributor

Rosuavio commented Mar 8, 2021

It also works on my machine.

image

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chingucoding just rebuilt and looks good now. Thanks for all the effort!

@marcelwgn
Copy link
Contributor Author

Awesome! Happy to help! Is there anything stopping a merge then?

@michael-hawker
Copy link
Member

@chingucoding nope, just going to be merging other PRs in first that we want to validate builds on as then it's harder to merge them. This one is easier to merge after as I know I won't have to wait for the CI or care about it stopping.

I'll get this merged in later this afternoon. Thanks for all the help! 🦙❤

@michael-hawker michael-hawker merged commit 0428cb2 into CommunityToolkit:master Mar 8, 2021
@marcelwgn marcelwgn deleted the dev/stringextensions-a11y branch March 8, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ♿ bug 🐛 An unexpected issue that highlights incorrect behavior extensions ⚡ sample app 🖼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Colored text in StringExtension sample is difficult to read
4 participants