Sample app updates for 7.0 #3824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since optimizing SwitchPresenter, the delayed loading being in another control's template was causing an issue where the cases weren't available to evaluate when SwitchPresenter was ready. Since we no longer listened to all downstream changes in SwitchPresenter this meant we never evaluated once the parent control was loaded. Added a couple of cases to ensure that once we're fully loaded we can evaluate again to ensure we pick a case. This also covers a case where if somehow the entire collection gets swapped out later. Added some extra checks ahead of the evaluate cases to break out early in case we don't need to update the Visual Tree.
Fix issue with version history display on About page Add Wiki Link Add MVVM Toolkit entry to sample for docs Clean-up ColorPickerPage sample
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
Sergio0694
approved these changes
Mar 10, 2021
Remove Custom NavigationView template, it should support everything we need now Remove workaround for WinUI 2.4 bug Add new workaround for another issue...
Have docs in release mode look at live branch of last shipped docs.
Can't add examples back as we haven't rebuilt the Graph Controls library yet.
8 tasks
|
This should be good to go now? Just need to do some final validation in release mode with the final docs. But think everything else is updated for merging back into the repo, the final part is still manual for me offline. |
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
azchohfi
approved these changes
Mar 11, 2021
This was referenced Mar 12, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lots
Smorgasbord of changes found or related to updating the Sample App for 7.0 shipping.
TODO