Merge pull request #159 from kyle-leonhard/nested-effect-updates

Avoid triggering nested updates in $effects

Author: wobsoriano

.changeset/cuddly-poems-melt.md

@@ -0,0 +1,5 @@
+---
+"svelte-sonner": patch
+---
+
+Avoid triggering nested $effect updates on dismissal

src/lib/Toast.svelte

@@ -186,7 +186,12 @@
 
 		initialHeight = finalHeight;
 
-		toastState.setHeight({ toastId: toast.id, height: finalHeight });
+		// setHeight reads heights and toasts state. Untrack the call
+		// to avoid triggering this effect when those are modified. e.g. toasts
+		// added and removed.
+		untrack(() => {
+			toastState.setHeight({ toastId: toast.id, height: finalHeight });
+		});
 	});
 
 	function deleteToast() {
@@ -265,7 +270,12 @@
 
 	$effect(() => {
 		if (toast.delete) {
-			deleteToast();
+			// deleteToast reads and writes the heights and toasts state.
+			// Untrack the call to avoid triggering nested updates.
+			// See https://github.com/wobsoriano/svelte-sonner/issues/151
+			untrack(() => {
+				deleteToast();
+			});
 		}
 	});