Skip to content

Commit 9b505bf

Browse files
stu1130xziya
stu1130
authored and
xziya
committed
Disable test coverage of C++ codebase on CI (apache#15981)
* disable test coverage on ci * address the comment * retrigger CI
1 parent 1a4cc18 commit 9b505bf

File tree

6 files changed

+72
-81
lines changed

6 files changed

+72
-81
lines changed

‎CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,8 @@ if(USE_TENSORRT)
233233
${ONNX_PROTO_LIBRARY} ${ONNX_LIBRARY} ${PROTOBUF_LIBRARY})
234234
endif()
235235

236+
# please note that when you enable this, you might run into an linker not being able to work properly due to large code injection.
237+
# you can find more information here https://github.com/apache/incubator-mxnet/issues/15971
236238
if(ENABLE_TESTCOVERAGE)
237239
message(STATUS "Compiling with test coverage support enabled. This will result in additional files being written to your source directory!")
238240
find_program( GCOV_PATH gcov )

‎Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ endif
109109
CFLAGS += -I$(TPARTYDIR)/mshadow/ -I$(TPARTYDIR)/dmlc-core/include -fPIC -I$(NNVM_PATH)/include -I$(DLPACK_PATH)/include -I$(TPARTYDIR)/tvm/include -Iinclude $(MSHADOW_CFLAGS)
110110
LDFLAGS = -pthread -ldl $(MSHADOW_LDFLAGS) $(DMLC_LDFLAGS)
111111

112+
# please note that when you enable this, you might run into an linker not being able to work properly due to large code injection.
113+
# you can find more information here https://github.com/apache/incubator-mxnet/issues/15971
112114
ifeq ($(ENABLE_TESTCOVERAGE), 1)
113115
CFLAGS += --coverage
114116
LDFLAGS += --coverage

‎ci/docker/runtime_functions.sh

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,6 @@ build_centos7_cpu() {
299299
make \
300300
DEV=1 \
301301
USE_LAPACK=1 \
302-
ENABLE_TESTCOVERAGE=1 \
303302
USE_LAPACK_PATH=/usr/lib64/liblapack.so \
304303
USE_BLAS=openblas \
305304
USE_MKLDNN=0 \
@@ -314,7 +313,6 @@ build_amzn_linux_cpu() {
314313
cmake \
315314
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
316315
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
317-
-DENABLE_TESTCOVERAGE=ON \
318316
-DUSE_CUDA=OFF\
319317
-DUSE_OPENCV=ON\
320318
-DUSE_OPENMP=ON\
@@ -335,7 +333,6 @@ build_centos7_mkldnn() {
335333
build_ccache_wrappers
336334
make \
337335
DEV=1 \
338-
ENABLE_TESTCOVERAGE=1 \
339336
USE_LAPACK=1 \
340337
USE_LAPACK_PATH=/usr/lib64/liblapack.so \
341338
USE_BLAS=openblas \
@@ -350,7 +347,6 @@ build_centos7_gpu() {
350347
build_ccache_wrappers
351348
make \
352349
DEV=1 \
353-
ENABLE_TESTCOVERAGE=1 \
354350
USE_LAPACK=1 \
355351
USE_LAPACK_PATH=/usr/lib64/liblapack.so \
356352
USE_BLAS=openblas \
@@ -374,7 +370,6 @@ build_ubuntu_cpu_openblas() {
374370
build_ccache_wrappers
375371
make \
376372
DEV=1 \
377-
ENABLE_TESTCOVERAGE=1 \
378373
USE_CPP_PACKAGE=1 \
379374
USE_BLAS=openblas \
380375
USE_MKLDNN=0 \
@@ -392,7 +387,6 @@ build_ubuntu_cpu_mkl() {
392387
export CXX="ccache g++"
393388
make \
394389
DEV=1 \
395-
ENABLE_TESTCOVERAGE=1 \
396390
USE_CPP_PACKAGE=1 \
397391
USE_BLAS=mkl \
398392
USE_MKLDNN=0 \
@@ -410,7 +404,6 @@ build_ubuntu_cpu_cmake_debug() {
410404
cmake \
411405
-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
412406
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
413-
-DENABLE_TESTCOVERAGE=ON \
414407
-DUSE_CUDA=OFF \
415408
-DUSE_MKL_IF_AVAILABLE=OFF \
416409
-DUSE_OPENMP=OFF \
@@ -461,7 +454,6 @@ build_ubuntu_cpu_clang39() {
461454
export CC=clang-3.9
462455
build_ccache_wrappers
463456
make \
464-
ENABLE_TESTCOVERAGE=1 \
465457
USE_CPP_PACKAGE=1 \
466458
USE_BLAS=openblas \
467459
USE_MKLDNN=0 \
@@ -479,7 +471,6 @@ build_ubuntu_cpu_clang60() {
479471
build_ccache_wrappers
480472

481473
make \
482-
ENABLE_TESTCOVERAGE=1 \
483474
USE_CPP_PACKAGE=1 \
484475
USE_BLAS=openblas \
485476
USE_MKLDNN=0 \
@@ -525,7 +516,6 @@ build_ubuntu_cpu_clang39_mkldnn() {
525516
build_ccache_wrappers
526517

527518
make \
528-
ENABLE_TESTCOVERAGE=1 \
529519
USE_CPP_PACKAGE=1 \
530520
USE_BLAS=openblas \
531521
USE_OPENMP=0 \
@@ -542,7 +532,6 @@ build_ubuntu_cpu_clang60_mkldnn() {
542532
build_ccache_wrappers
543533

544534
make \
545-
ENABLE_TESTCOVERAGE=1 \
546535
USE_CPP_PACKAGE=1 \
547536
USE_BLAS=openblas \
548537
USE_OPENMP=1 \
@@ -557,7 +546,6 @@ build_ubuntu_cpu_mkldnn() {
557546

558547
make \
559548
DEV=1 \
560-
ENABLE_TESTCOVERAGE=1 \
561549
USE_CPP_PACKAGE=1 \
562550
USE_BLAS=openblas \
563551
USE_SIGNAL_HANDLER=1 \
@@ -571,7 +559,6 @@ build_ubuntu_cpu_mkldnn_mkl() {
571559

572560
make \
573561
DEV=1 \
574-
ENABLE_TESTCOVERAGE=1 \
575562
USE_CPP_PACKAGE=1 \
576563
USE_BLAS=mkl \
577564
USE_SIGNAL_HANDLER=1 \
@@ -635,7 +622,6 @@ build_ubuntu_gpu_tensorrt() {
635622
-DUSE_OPENMP=0 \
636623
-DUSE_MKLDNN=0 \
637624
-DUSE_MKL_IF_AVAILABLE=OFF \
638-
-DENABLE_TESTCOVERAGE=ON \
639625
-DCUDA_ARCH_NAME=Manual \
640626
-DCUDA_ARCH_BIN=$CI_CMAKE_CUDA_ARCH_BIN \
641627
-G Ninja \
@@ -651,7 +637,6 @@ build_ubuntu_gpu_mkldnn() {
651637

652638
make \
653639
DEV=1 \
654-
ENABLE_TESTCOVERAGE=1 \
655640
USE_CPP_PACKAGE=1 \
656641
USE_BLAS=openblas \
657642
USE_CUDA=1 \
@@ -669,7 +654,6 @@ build_ubuntu_gpu_mkldnn_nocudnn() {
669654

670655
make \
671656
DEV=1 \
672-
ENABLE_TESTCOVERAGE=1 \
673657
USE_BLAS=openblas \
674658
USE_CUDA=1 \
675659
USE_CUDA_PATH=/usr/local/cuda \
@@ -684,7 +668,6 @@ build_ubuntu_gpu_cuda101_cudnn7() {
684668
build_ccache_wrappers
685669
make \
686670
DEV=1 \
687-
ENABLE_TESTCOVERAGE=1 \
688671
USE_BLAS=openblas \
689672
USE_MKLDNN=0 \
690673
USE_CUDA=1 \
@@ -706,8 +689,7 @@ build_ubuntu_amalgamation() {
706689
build_ccache_wrappers
707690
make -C amalgamation/ clean
708691
make -C amalgamation/ \
709-
USE_BLAS=openblas \
710-
ENABLE_TESTCOVERAGE=1
692+
USE_BLAS=openblas
711693
}
712694

713695
build_ubuntu_amalgamation_min() {
@@ -717,8 +699,7 @@ build_ubuntu_amalgamation_min() {
717699
make -C amalgamation/ clean
718700
make -C amalgamation/ \
719701
USE_BLAS=openblas \
720-
MIN=1 \
721-
ENABLE_TESTCOVERAGE=1
702+
MIN=1
722703
}
723704

724705
build_ubuntu_gpu_cmake_mkldnn() {
@@ -730,7 +711,6 @@ build_ubuntu_gpu_cmake_mkldnn() {
730711
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
731712
-DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
732713
-DUSE_SIGNAL_HANDLER=ON \
733-
-DENABLE_TESTCOVERAGE=ON \
734714
-DUSE_CUDA=1 \
735715
-DUSE_CUDNN=1 \
736716
-DUSE_MKLML_MKL=1 \
@@ -755,7 +735,6 @@ build_ubuntu_gpu_cmake() {
755735
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
756736
-DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
757737
-DUSE_SIGNAL_HANDLER=ON \
758-
-DENABLE_TESTCOVERAGE=ON \
759738
-DUSE_CUDA=ON \
760739
-DUSE_CUDNN=ON \
761740
-DUSE_MKL_IF_AVAILABLE=OFF \
@@ -781,7 +760,6 @@ build_ubuntu_cpu_large_tensor() {
781760
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
782761
-DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
783762
-DUSE_SIGNAL_HANDLER=ON \
784-
-DENABLE_TESTCOVERAGE=ON \
785763
-DUSE_CUDA=OFF \
786764
-DUSE_CUDNN=OFF \
787765
-DUSE_MKLDNN=OFF \
@@ -802,7 +780,6 @@ build_ubuntu_gpu_large_tensor() {
802780
-DCMAKE_C_COMPILER_LAUNCHER=ccache \
803781
-DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
804782
-DUSE_SIGNAL_HANDLER=ON \
805-
-DENABLE_TESTCOVERAGE=ON \
806783
-DUSE_CUDA=ON \
807784
-DUSE_CUDNN=ON \
808785
-DUSE_MKL_IF_AVAILABLE=OFF \

0 commit comments

Comments
 (0)