spf command prompt enhancement

[lazysegtree]

PR

• feat: added a Command-Prompt for SuperFile specific actions #736
• Feat/cmd prompt - Original PR #736 by @Rocco-Gossmann #752

Goal

• Instead of a one line command shell at the bottom, we would have a command shell as an overlay modal . It would be span multiple lines and can support output, suggestions etc.
• Add some spf commands. Users can press '>' to change to spf command mode, instead of shell mode and the run spf commands.

Vocabulary
Shell command - Command run at users shell
SPF command - Superfile specific commands. (like split - split panels)
SPF Prompt - The overlay modal that allows users to run SPF or shell commands
SPF Prompt (Shell mode) - The overlay modal in a mode that allows you to run shell commands
SPF Prompt (SPF mode) - The overlay modal in a mode that allows you to run SPF commands

Idea

User would press : to open the SPF Prompt in Shell mode
Then he can press > to switch to SPF mode, or start typing directly to execute normal shell commands
On pressing > Terminal will switch to SPF mode, and > written on text input will get cleared.

• Press : then mkdir hi - Shell command execution
• Press > then type split - SPF command execution
• Press > then type cd ${MY_ENV_VAR} - SPF command execution

Edit - User can directly press > to get started with the prompt mode in the first place.

[lazysegtree]

Originally posted by @Rocco-Gossman at #736 (comment)

---

@Rocco-Gossmann The PR is getting bloated with comments. Could you join discord ? We will continue our discussion there. Or lets create a discussion on discussion tab.

@lazysegtree @yorukot
If you don't mind, I think I'll drop out at this point.

1.) I don't like Discord. Don't have an account, Don't want one.

2.) You clearly want this PR to be more, than I ever intended it to be.

3.) Just for the record. I created this PR after this comment by @lazysegtree #733 (comment)

The idea was to NOT confuse the user between Command-Prompt and Shell-Commandline.
Now you are walking back on that and making the Command-Prompt into the Shell-Commandline.
Triggering the actual Command-Prompt functions via a Prefix.

At this point, we could have just keept the original Shell-Commandline and just replaced the spf-prefix (I implemented here: #733) with something else.

---

[lazysegtree]

@Rocco-Gossmann Moving the discussion here.

Please see the main discussion message to get clarification about the idea.

The idea was to NOT confuse the user between Command-Prompt and Shell-Commandline.

And we are not confusing the user. Pressing : is shell mode ( It would say that on SPF Prompt title as well ), and then pressing > would be spf mode.

Now you are walking back on that and making the Command-Prompt into the Shell-Commandline.
Triggering the actual Command-Prompt functions via a Prefix.
At this point, we could have just keept the original Shell-Commandline and just replaced the spf-prefix (I implemented here: #733) with something else.

This is different. We would have a different mode spf prompt. Its not like a specific prefix will trigger SPF commands, and else we would have Shell commands.

And its a big overlay modal at the center this time, not a smaller one line shell at bottom.

[lazysegtree]

Some screenshots

Shell command

On pressing enter

Prompt example

On pressing enter

[lazysegtree]

Video - https://www.loom.com/share/99b346eef1e84c1d9fdf2ed6400522c1

[lazysegtree]

@Rocco-Gossmann FYI. We are done with the initial development of the feature.
Next AI are listed in this issue

• Leftover items in spf prompt feature. #753

Thanks for the idea, and initial work. Most of the design is based on your contribution.
You can verify that the feature now aligns with your vision ( I tried to make implement it like that ). Please provide any feedback if you think its better to change it further.

Superfile is for the users of superfile, we authors dont want force our ideas and what we think is best for user. Hence please feel free to raise any concerns.

PRs

• feat: added a Command-Prompt for SuperFile specific actions #736
• Feat/cmd prompt - Original PR #736 by @Rocco-Gossmann #752

[Rocco-Gossmann]

Thank YOU, for taking on this Task and giving it the polish it needed. It looks awesome.
The color for the response at the bottom is a very nice touch.

I think being able to switch modes like this is ok. All though I personally would prefer starting in Prompt-Mode instead of Shell mode. However I acknowledge, that I'm not most people, so it is fine.

Maybe we can add some sort of startup_prompt_mode option. For those people who want to use the Prompt-Commands more than the Shell-Commands.

Thank you very much.
Maybe I'll have a look at what I can do about the "Shell-Output".

[lazysegtree]

@Rocco-Gossmann You can start directly with prompt mode with pressing '>'. Sorry forgot to mention that.
':' - start with shell mode
'>' - start with prompt mode directly