Skip to content

Commit ca503ce

Browse files
committed
DebuggerDisplay improvements
1 parent a246b68 commit ca503ce

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+57
-184
lines changed

src/redmine-net-api/Types/Attachment.cs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -256,16 +256,7 @@ public override int GetHashCode()
256256
}
257257
#endregion
258258

259-
private string DebuggerDisplay =>
260-
$@"[{nameof(Attachment)}:
261-
{ToString()},
262-
FileName={FileName},
263-
FileSize={FileSize.ToString(CultureInfo.InvariantCulture)},
264-
ContentType={ContentType},
265-
Description={Description},
266-
ContentUrl={ContentUrl},
267-
Author={Author},
268-
CreatedOn={CreatedOn?.ToString("u", CultureInfo.InvariantCulture)}]";
259+
private string DebuggerDisplay =>$"[Attachment: Id={Id.ToInvariantString()}, FileName={FileName}, FileSize={FileSize.ToInvariantString()}]";
269260

270261
/// <summary>
271262
///

src/redmine-net-api/Types/ChangeSet.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,7 @@ public override int GetHashCode()
232232
///
233233
/// </summary>
234234
/// <returns></returns>
235-
private string DebuggerDisplay =>
236-
$@"[{nameof(ChangeSet)}:
237-
Revision={Revision.ToString(CultureInfo.InvariantCulture)},
238-
User='{User}',
239-
CommittedOn={CommittedOn?.ToString("u", CultureInfo.InvariantCulture)},
240-
Comments='{Comments}']";
235+
private string DebuggerDisplay => $" ChangeSet: Revision={Revision}, CommittedOn={CommittedOn?.ToString("u", CultureInfo.InvariantCulture)}]";
241236

242237
}
243238
}

src/redmine-net-api/Types/CustomField.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -290,22 +290,6 @@ public override int GetHashCode()
290290
}
291291
#endregion
292292

293-
private string DebuggerDisplay =>
294-
$@"[{nameof(CustomField)}: {ToString()}
295-
, CustomizedType={CustomizedType}
296-
, Description={Description}
297-
, FieldFormat={FieldFormat}
298-
, Regexp={Regexp}
299-
, MinLength={MinLength?.ToString(CultureInfo.InvariantCulture)}
300-
, MaxLength={MaxLength?.ToString(CultureInfo.InvariantCulture)}
301-
, IsRequired={IsRequired.ToString(CultureInfo.InvariantCulture)}
302-
, IsFilter={IsFilter.ToString(CultureInfo.InvariantCulture)}
303-
, Searchable={Searchable.ToString(CultureInfo.InvariantCulture)}
304-
, Multiple={Multiple.ToString(CultureInfo.InvariantCulture)}
305-
, DefaultValue={DefaultValue}
306-
, Visible={Visible.ToString(CultureInfo.InvariantCulture)}
307-
, PossibleValues={PossibleValues.Dump()}
308-
, Trackers={Trackers.Dump()}
309-
, Roles={Roles.Dump()}]";
293+
private string DebuggerDisplay => $"[CustomField: Id={Id.ToInvariantString()}, Name={Name}]";
310294
}
311295
}

src/redmine-net-api/Types/CustomFieldPossibleValue.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public override int GetHashCode()
192192
///
193193
/// </summary>
194194
/// <returns></returns>
195-
private string DebuggerDisplay => $"[{nameof(CustomFieldPossibleValue)}: Label:{Label}, Value:{Value}]";
195+
private string DebuggerDisplay => $"[CustomFieldPossibleValue: Label:{Label}, Value:{Value}]";
196196

197197
}
198198
}

src/redmine-net-api/Types/CustomFieldRole.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ limitations under the License.
1616

1717
using System.Diagnostics;
1818
using System.Xml.Serialization;
19+
using Redmine.Net.Api.Extensions;
1920

2021
namespace Redmine.Net.Api.Types
2122
{
@@ -41,7 +42,7 @@ internal CustomFieldRole(int id, string name)
4142
///
4243
/// </summary>
4344
/// <returns></returns>
44-
private string DebuggerDisplay => $"[{nameof(CustomFieldRole)}: {ToString()}]";
45+
private string DebuggerDisplay => $"[CustomFieldRole: Id={Id.ToInvariantString()}, Name={Name}]";
4546

4647
}
4748
}

src/redmine-net-api/Types/CustomFieldValue.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,6 @@ public CustomFieldValue Clone(bool resetId)
217217
///
218218
/// </summary>
219219
/// <returns></returns>
220-
private string DebuggerDisplay => $"[{nameof(CustomFieldValue)}: {Info}]";
220+
private string DebuggerDisplay => $"[CustomFieldValue: {Info}]";
221221
}
222222
}

src/redmine-net-api/Types/Detail.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public override int GetHashCode()
251251
///
252252
/// </summary>
253253
/// <returns></returns>
254-
private string DebuggerDisplay => $"[{nameof(Detail)}: Property={Property}, Name={Name}, OldValue={OldValue}, NewValue={NewValue}]";
254+
private string DebuggerDisplay => $"[Detail: Property={Property}, Name={Name}, OldValue={OldValue}, NewValue={NewValue}]";
255255

256256
}
257257
}

src/redmine-net-api/Types/DocumentCategory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public override int GetHashCode()
193193
///
194194
/// </summary>
195195
/// <returns></returns>
196-
private string DebuggerDisplay => $"[{nameof(DocumentCategory)}, IsDefault={IsDefault.ToString(CultureInfo.InvariantCulture)}, IsActive={IsActive.ToString(CultureInfo.InvariantCulture)}]";
196+
private string DebuggerDisplay => $"[DocumentCategory: Id={Id.ToInvariantString()}, Name={Name}, IsDefault={IsDefault.ToInvariantString()}, IsActive={IsActive.ToInvariantString()}]";
197197

198198
}
199199
}

src/redmine-net-api/Types/Error.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public override int GetHashCode()
176176
///
177177
/// </summary>
178178
/// <returns></returns>
179-
private string DebuggerDisplay => $"[{nameof(Error)}: {Info}]";
179+
private string DebuggerDisplay => $"[Error: {Info}]";
180180

181181
}
182182
}

src/redmine-net-api/Types/File.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ public override int GetHashCode()
283283
///
284284
/// </summary>
285285
/// <returns></returns>
286-
private string DebuggerDisplay => $"[{nameof(File)}: {ToString()}, Name={Filename}]";
286+
private string DebuggerDisplay => $"[File: {Id.ToInvariantString()}, Name={Filename}]";
287287

288288
}
289289
}

src/redmine-net-api/Types/Group.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public override int GetHashCode()
227227
///
228228
/// </summary>
229229
/// <returns></returns>
230-
private string DebuggerDisplay => $"[{nameof(Group)}: {ToString()}, Users={Users.Dump()}, CustomFields={CustomFields.Dump()}, Memberships={Memberships.Dump()}]";
230+
private string DebuggerDisplay => $"[Group: Id={Id.ToInvariantString()}, Name={Name}]";
231231

232232

233233
/// <summary>

src/redmine-net-api/Types/GroupUser.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
using System.Diagnostics;
1818
using System.Globalization;
1919
using System.Xml.Serialization;
20+
using Redmine.Net.Api.Extensions;
2021

2122
namespace Redmine.Net.Api.Types
2223
{
@@ -38,7 +39,7 @@ public sealed class GroupUser : IdentifiableName, IValue
3839
///
3940
/// </summary>
4041
/// <returns></returns>
41-
private string DebuggerDisplay => $"[{nameof(GroupUser)}: {ToString()}]";
42+
private string DebuggerDisplay => $"[GroupUser: Id={Id.ToInvariantString()}, Name={Name}]";
4243

4344
}
4445
}

src/redmine-net-api/Types/Identifiable.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ limitations under the License.
2121
using System.Xml.Schema;
2222
using System.Xml.Serialization;
2323
using Newtonsoft.Json;
24+
using Redmine.Net.Api.Extensions;
2425
using Redmine.Net.Api.Internals;
2526
using Redmine.Net.Api.Serialization;
2627
using NotImplementedException = System.NotImplementedException;
@@ -157,7 +158,7 @@ public override int GetHashCode()
157158
///
158159
/// </summary>
159160
/// <returns></returns>
160-
private string DebuggerDisplay => $"Id={Id.ToString(CultureInfo.InvariantCulture)}";
161+
private string DebuggerDisplay => $"Id={Id.ToInvariantString()}";
161162

162163
/// <summary>
163164
///

src/redmine-net-api/Types/IdentifiableName.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ public override int GetHashCode()
224224
///
225225
/// </summary>
226226
/// <returns></returns>
227-
private string DebuggerDisplay => $"[{nameof(IdentifiableName)}: {base.ToString()}, Name={Name}]";
227+
private string DebuggerDisplay => $"[IdentifiableName: Id={Id.ToInvariantString()}, Name={Name}]";
228228

229229
/// <summary>
230230
///

src/redmine-net-api/Types/Issue.cs

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -650,30 +650,6 @@ public IdentifiableName AsParent()
650650
///
651651
/// </summary>
652652
/// <returns></returns>
653-
private string DebuggerDisplay =>
654-
$@"[{nameof(Issue)}: {ToString()}, Project={Project}, Tracker={Tracker}, Status={Status},
655-
Priority={Priority}, Author={Author}, Category={Category}, Subject={Subject}, Description={Description},
656-
StartDate={StartDate?.ToString("u", CultureInfo.InvariantCulture)},
657-
DueDate={DueDate?.ToString("u", CultureInfo.InvariantCulture)},
658-
DoneRatio={DoneRatio?.ToString("F", CultureInfo.InvariantCulture)},
659-
PrivateNotes={PrivateNotes.ToString(CultureInfo.InvariantCulture)},
660-
EstimatedHours={EstimatedHours?.ToString("F", CultureInfo.InvariantCulture)},
661-
SpentHours={SpentHours?.ToString("F", CultureInfo.InvariantCulture)},
662-
CustomFields={CustomFields.Dump()},
663-
CreatedOn={CreatedOn?.ToString("u", CultureInfo.InvariantCulture)},
664-
UpdatedOn={UpdatedOn?.ToString("u", CultureInfo.InvariantCulture)},
665-
ClosedOn={ClosedOn?.ToString("u", CultureInfo.InvariantCulture)},
666-
Notes={Notes},
667-
AssignedTo={AssignedTo},
668-
ParentIssue={ParentIssue},
669-
FixedVersion={FixedVersion},
670-
IsPrivate={IsPrivate.ToString(CultureInfo.InvariantCulture)},
671-
Journals={Journals.Dump()},
672-
ChangeSets={ChangeSets.Dump()},
673-
Attachments={Attachments.Dump()},
674-
Relations={Relations.Dump()},
675-
Children={Children.Dump()},
676-
Uploads={Uploads.Dump()},
677-
Watchers={Watchers.Dump()}]";
653+
private string DebuggerDisplay => $"[Issue:Id={Id.ToInvariantString()}, Status={Status?.Name}, Priority={Priority?.Name}, DoneRatio={DoneRatio?.ToString("F", CultureInfo.InvariantCulture)},IsPrivate={IsPrivate.ToInvariantString()}]";
678654
}
679655
}

src/redmine-net-api/Types/IssueAllowedStatus.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,6 @@ public override int GetHashCode()
129129
return !Equals(left, right);
130130
}
131131

132-
private string DebuggerDisplay => $"[{nameof(IssueAllowedStatus)}: {ToString()}]";
132+
private string DebuggerDisplay => $"[IssueAllowedStatus: Id={Id.ToInvariantString()}, Name={Name}]";
133133
}
134134
}

src/redmine-net-api/Types/IssueCategory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ public override int GetHashCode()
209209
///
210210
/// </summary>
211211
/// <returns></returns>
212-
private string DebuggerDisplay => $"[{nameof(IssueCategory)}: {ToString()}, Project={Project}, AssignTo={AssignTo}, Name={Name}]";
212+
private string DebuggerDisplay => $"[IssueCategory: Id={Id.ToInvariantString()}, Name={Name}]";
213213

214214
}
215215
}

src/redmine-net-api/Types/IssueChild.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,6 @@ public override int GetHashCode()
191191
///
192192
/// </summary>
193193
/// <returns></returns>
194-
private string DebuggerDisplay => $"[{nameof(IssueChild)}: {ToString()}, Tracker={Tracker}, Subject={Subject}]";
194+
private string DebuggerDisplay => $"[IssueChild: Id={Id.ToInvariantString()}]";
195195
}
196196
}

src/redmine-net-api/Types/IssueCustomField.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,6 @@ public static string GetValue(object item)
325325
///
326326
/// </summary>
327327
/// <returns></returns>
328-
private string DebuggerDisplay => $"[{nameof(IssueCustomField)}: {ToString()} Values={Values.Dump()}, Multiple={Multiple.ToString(CultureInfo.InvariantCulture)}]";
328+
private string DebuggerDisplay => $"[IssueCustomField: Id={Id.ToInvariantString()}, Name={Name}, Multiple={Multiple.ToInvariantString()}]";
329329
}
330330
}

src/redmine-net-api/Types/IssuePriority.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public override int GetHashCode()
176176
///
177177
/// </summary>
178178
/// <returns></returns>
179-
private string DebuggerDisplay => $"[IssuePriority: {ToString()}, IsDefault={IsDefault.ToString(CultureInfo.InvariantCulture)}, IsActive={IsActive.ToString(CultureInfo.InvariantCulture)}]";
179+
private string DebuggerDisplay => $"[IssuePriority: Id={Id.ToInvariantString()},Name={Name}, IsDefault={IsDefault.ToInvariantString()},IsActive={IsActive.ToInvariantString()}]";
180180

181181
}
182182
}

src/redmine-net-api/Types/IssueRelation.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,7 @@ public override int GetHashCode()
283283
///
284284
/// </summary>
285285
/// <returns></returns>
286-
private string DebuggerDisplay => $@"[{nameof(IssueRelation)}: {ToString()},
287-
IssueId={IssueId.ToString(CultureInfo.InvariantCulture)},
288-
IssueToId={IssueToId.ToString(CultureInfo.InvariantCulture)},
289-
Type={Type:G},
290-
Delay={Delay?.ToString(CultureInfo.InvariantCulture)}]";
286+
private string DebuggerDisplay => $"[IssueRelation: Id={Id.ToInvariantString()}, IssueId={IssueId.ToInvariantString()}, Type={Type:G}, Delay={Delay?.ToInvariantString()}]";
291287

292288
/// <summary>
293289
///

src/redmine-net-api/Types/IssueStatus.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ public override int GetHashCode()
238238
///
239239
/// </summary>
240240
/// <returns></returns>
241-
private string DebuggerDisplay => $"[{nameof(IssueStatus)}: {ToString()}, IsDefault={IsDefault.ToString(CultureInfo.InvariantCulture)}, IsClosed={IsClosed.ToString(CultureInfo.InvariantCulture)}]";
241+
private string DebuggerDisplay => $"[IssueStatus: Id={Id.ToInvariantString()}, Name={Name}, IsDefault={IsDefault.ToInvariantString()}, IsClosed={IsClosed.ToInvariantString()}]";
242242

243243
}
244244
}

src/redmine-net-api/Types/Journal.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public override int GetHashCode()
251251
///
252252
/// </summary>
253253
/// <returns></returns>
254-
private string DebuggerDisplay => $"[{nameof(Journal)}: {ToString()}, User={User}, Notes={Notes}, CreatedOn={CreatedOn?.ToString("u", CultureInfo.InvariantCulture)}, Details={Details.Dump()}]";
254+
private string DebuggerDisplay => $"[Journal: Id={Id.ToInvariantString()}, CreatedOn={CreatedOn?.ToString("u", CultureInfo.InvariantCulture)}]";
255255

256256
/// <summary>
257257
///

src/redmine-net-api/Types/Membership.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,6 @@ public override int GetHashCode()
186186
///
187187
/// </summary>
188188
/// <returns></returns>
189-
private string DebuggerDisplay => $"[{nameof(Membership)}: {ToString()}, Group={Group}, Project={Project}, User={User}, Roles={Roles.Dump()}]";
189+
private string DebuggerDisplay => $"[Membership: Id={Id.ToInvariantString()}]";
190190
}
191191
}

src/redmine-net-api/Types/MembershipRole.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ public override int GetHashCode()
179179
///
180180
/// </summary>
181181
/// <returns></returns>
182-
private string DebuggerDisplay => $"[MembershipRole: {ToString()}, Inherited={Inherited.ToString(CultureInfo.InvariantCulture)}]";
183-
182+
private string DebuggerDisplay => $"[MembershipRole: Id={Id.ToInvariantString()}, Name={Name}, Inherited={Inherited.ToInvariantString()}]";
184183
}
185184
}

src/redmine-net-api/Types/MyAccount.cs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -252,16 +252,6 @@ public override int GetHashCode()
252252
return !Equals(left, right);
253253
}
254254

255-
private string DebuggerDisplay => $@"[ {nameof(MyAccount)}:
256-
Id={Id.ToString(CultureInfo.InvariantCulture)},
257-
Login={Login},
258-
ApiKey={ApiKey},
259-
FirstName={FirstName},
260-
LastName={LastName},
261-
Email={Email},
262-
IsAdmin={IsAdmin.ToString(CultureInfo.InvariantCulture).ToLowerInv()},
263-
CreatedOn={CreatedOn?.ToString("u", CultureInfo.InvariantCulture)},
264-
LastLoginOn={LastLoginOn?.ToString("u", CultureInfo.InvariantCulture)},
265-
CustomFields={CustomFields.Dump()}]";
255+
private string DebuggerDisplay => $"[MyAccount: Id={Id.ToInvariantString()}, Login={Login}, IsAdmin={IsAdmin.ToInvariantString()}]";
266256
}
267257
}

src/redmine-net-api/Types/MyAccountCustomField.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public override int GetHashCode()
168168
///
169169
/// </summary>
170170
/// <returns></returns>
171-
private string DebuggerDisplay => $"[{nameof(MyAccountCustomField)}: {ToString()}, Value: {Value}]";
171+
private string DebuggerDisplay => $"[MyAccountCustomField: Id={Id.ToInvariantString()}, Name={Name}, Value: {Value}]";
172172

173173
}
174174
}

src/redmine-net-api/Types/News.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public override int GetHashCode()
282282
///
283283
/// </summary>
284284
/// <returns></returns>
285-
private string DebuggerDisplay => $"[{nameof(News)}: {ToString()}, Project={Project}, Author={Author}, Title={Title}, Summary={Summary}, Description={Description}, CreatedOn={CreatedOn?.ToString("u", CultureInfo.InvariantCulture)}]";
285+
private string DebuggerDisplay => $"[News: Id={Id.ToInvariantString()}, Title={Title}]";
286286

287287
}
288288
}

src/redmine-net-api/Types/NewsComment.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ limitations under the License.
1919
using System.Xml;
2020
using System.Xml.Serialization;
2121
using Newtonsoft.Json;
22+
using Redmine.Net.Api.Extensions;
2223
using Redmine.Net.Api.Internals;
2324

2425
namespace Redmine.Net.Api.Types
@@ -157,9 +158,6 @@ public override int GetHashCode()
157158
return !Equals(left, right);
158159
}
159160

160-
private string DebuggerDisplay => $@"[{nameof(IssueAllowedStatus)}: {ToString()},
161-
{nameof(NewsComment)}: {ToString()},
162-
Author={Author},
163-
CONTENT={Content}]";
161+
private string DebuggerDisplay => $"[NewsComment: Id={Id.ToInvariantString()}]";
164162
}
165163
}

src/redmine-net-api/Types/Permission.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public override int GetHashCode()
155155
///
156156
/// </summary>
157157
/// <returns></returns>
158-
private string DebuggerDisplay => $"[{nameof(Permission)}: {Info}]";
158+
private string DebuggerDisplay => $"[Permission: {Info}]";
159159

160160
}
161161
}

0 commit comments

Comments
 (0)