Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit ef53bf6

Browse files
committed
Merge branch 'hotix/qa-tools' into develop
Forward port #208 Forward port #222 Forward port #228 Forward port #230 Conflicts: src/Controller/Plugin/Forward.php test/Controller/ActionControllerTest.php test/Controller/ControllerManagerTest.php test/Controller/Plugin/ForwardTest.php test/Controller/RestfulControllerTest.php test/Controller/TestAsset/ControllerLoaderAbstractFactory.php test/Service/ServiceListenerFactoryTest.php test/Service/ServiceManagerConfigTest.php test/Service/ViewHelperManagerFactoryTest.php
2 parents 3f40c46 + ee6a94d commit ef53bf6

File tree

106 files changed

+1526
-1010
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

106 files changed

+1526
-1010
lines changed

.php_cs

Lines changed: 0 additions & 45 deletions
This file was deleted.

.travis.yml

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ cache:
1515

1616
env:
1717
global:
18+
- COMPOSER_ARGS="--no-interaction"
19+
- COVERAGE_DEPS="satooshi/php-coveralls"
20+
- LEGACY_DEPS="phpunit/phpunit"
1821
- SITE_URL: https://zendframework.github.io/zend-mvc
1922
- GH_USER_NAME: "Matthew Weier O'Phinney"
2023
- GH_USER_EMAIL: [email protected]
@@ -30,12 +33,12 @@ matrix:
3033
- php: 5.6
3134
env:
3235
- DEPS=locked
33-
- TEST_COVERAGE=true
3436
- DEPLOY_DOCS="$(if [[ $TRAVIS_BRANCH == 'master' && $TRAVIS_PULL_REQUEST == 'false' ]]; then echo -n 'true' ; else echo -n 'false' ; fi)"
3537
- PATH="$HOME/.local/bin:$PATH"
3638
- php: 5.6
3739
env:
3840
- DEPS=latest
41+
- TEST_COVERAGE=true
3942
- php: 7
4043
env:
4144
- DEPS=lowest
@@ -67,24 +70,17 @@ matrix:
6770
allow_failures:
6871
- php: hhvm
6972

70-
env:
71-
global:
72-
- COMPOSER_ARGS="--no-interaction --ignore-platform-reqs"
73-
74-
notifications:
75-
irc: "irc.freenode.org#zftalk.dev"
76-
email: false
77-
7873
before_install:
7974
- travis_retry composer self-update
8075
- if [[ $TRAVIS_PHP_VERSION != "hhvm" && $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini ; fi
8176

8277
install:
78+
- travis_retry composer install $COMPOSER_ARGS --ignore-platform-reqs
79+
- if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi
8380
- if [[ $DEPS == 'latest' ]]; then travis_retry composer update $COMPOSER_ARGS ; fi
8481
- if [[ $DEPS == 'lowest' ]]; then travis_retry composer update --prefer-lowest --prefer-stable $COMPOSER_ARGS ; fi
85-
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS satooshi/php-coveralls:^1.0 ; fi
86-
- travis_retry composer install $COMPOSER_ARGS
87-
- composer show --installed
82+
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS $COVERAGE_DEPS ; fi
83+
- composer show
8884

8985
script:
9086
- if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; else composer test ; fi
@@ -96,3 +92,11 @@ after_script:
9692

9793
after_success:
9894
- if [[ $DEPLOY_DOCS == "true" ]]; then ./zf-mkdoc-theme/deploy.sh ; fi
95+
96+
notifications:
97+
email: false
98+
slack:
99+
rooms:
100+
- secure: "Izby0l/9kitKgdtpNsG4wpz1dENiAlBx6BTv54woOue+DB0XPpGV2kRs7Ta0u0neR3Spy1TjAIwQxtWp4SBPRyr99TAvjBmhrV8EHzdQvo3OosHP8VjXCyNTUbI5QhSW9I0UovQ+/Sd5CIQbckVLBs/YTp7MC9LhV/dBxRBM0GIO8EfkTtr7v1qYNmr6rVPGndco8zJUOSB/snSoLt/g2hk8WykAw7FaVpB/OdnAVmzy8rMRAYdqeZZjXdxoHebXF+osVvoBUgbdp2czGiv4jAGOWpRCqA6N4XaYWjqdL0kNCLvO/+LwGeinw2qAiHpm5g4xLhtpCC1mQNqnAOkVWZB9KnGjNcT9KfKD/6NO7AvQd+9LkTNII1+MAHhiwGwr2/JfXuepGuOVx/Jjto5PfZtZKBTCJb64JvacGNY3xY9n0yMpqS6rnSLW/5APq6HV0ufuu/nDDVLP5rJ4g//LHXepLC187QOkRcFfUfeVTscIpGLY8GrZY770XWLkFsR5VpAgBE40jRkqKtl/A7E2wJQ+mQ5YR6WP3vxzZFvnTC9Ut7WZo3RSZRwkwwvSdixydw739Afn/iywznpY1KUifgC2tqyI+dV0dra06hVsA579FDsZtCNHIXadSs/OMGUgoccdVNwlngN5Gxj28I1NugXeh2YGgTanJY0EFgg+Bsg="
101+
on_success: change
102+
on_failure: always

CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,24 +77,24 @@ To do so:
7777

7878
## Running Coding Standards Checks
7979

80-
This component uses [php-cs-fixer](http://cs.sensiolabs.org/) for coding
80+
This component uses [phpcs](https://github.com/squizlabs/PHP_CodeSniffer) for coding
8181
standards checks, and provides configuration for our selected checks.
82-
`php-cs-fixer` is installed by default via Composer.
82+
`phpcs` is installed by default via Composer.
8383

8484
To run checks only:
8585

8686
```console
87-
$ ./vendor/bin/php-cs-fixer fix . -v --diff --dry-run --config-file=.php_cs
87+
$ composer cs-check
8888
```
8989

90-
To have `php-cs-fixer` attempt to fix problems for you, omit the `--dry-run`
91-
flag:
90+
`phpcs` also includes a tool for fixing most CS violations, `phpcbf`:
91+
9292

9393
```console
94-
$ ./vendor/bin/php-cs-fixer fix . -v --diff --config-file=.php_cs
94+
$ composer cs-fix
9595
```
9696

97-
If you allow php-cs-fixer to fix CS issues, please re-run the tests to ensure
97+
If you allow `phpcbf` to fix CS issues, please re-run the tests to ensure
9898
they pass, and make sure you add and commit the changes after verification.
9999

100100
## Recommended Workflow for Contributions

composer.json

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,21 @@
1313
}
1414
},
1515
"require": {
16+
"container-interop/container-interop": "^1.1",
1617
"php": "^5.6 || ^7.0",
1718
"zendframework/zend-eventmanager": "^3.0",
1819
"zendframework/zend-http": "^2.5.4",
1920
"zendframework/zend-modulemanager": "^2.7.1",
2021
"zendframework/zend-router": "^3.0.1",
2122
"zendframework/zend-servicemanager": "^3.0.3",
2223
"zendframework/zend-stdlib": "^3.0",
23-
"zendframework/zend-view": "^2.6.7",
24-
"container-interop/container-interop": "^1.1"
24+
"zendframework/zend-view": "^2.6.7"
2525
},
2626
"require-dev": {
27+
"phpunit/phpunit": "^6.0.7 || ^5.7.14",
28+
"zendframework/zend-coding-standard": "~1.0.0",
2729
"zendframework/zend-json": "^2.6.1 || ^3.0",
28-
"zendframework/zend-psr7bridge": "^0.2",
29-
"fabpot/php-cs-fixer": "1.7.*",
30-
"phpunit/phpunit": "^4.5"
30+
"zendframework/zend-psr7bridge": "^0.2"
3131
},
3232
"suggest": {
3333
"zendframework/zend-json": "(^2.6.1 || ^3.0) To auto-deserialize JSON body content in AbstractRestfulController extensions, when json_decode is unavailable",
@@ -40,6 +40,9 @@
4040
"zendframework/zend-psr7bridge": "(^0.2) To consume PSR-7 middleware within the MVC workflow",
4141
"zendframework/zend-servicemanager-di": "zend-servicemanager-di provides utilities for integrating zend-di and zend-servicemanager in your zend-mvc application"
4242
},
43+
"config": {
44+
"sort-packages": true
45+
},
4346
"extra": {
4447
"branch-alias": {
4548
"dev-master": "3.0-dev",
@@ -49,17 +52,20 @@
4952
"autoload-dev": {
5053
"psr-4": {
5154
"ZendTest\\Mvc\\": "test/"
52-
}
55+
},
56+
"files": [
57+
"test/_autoload.php"
58+
]
5359
},
5460
"scripts": {
5561
"check": [
5662
"@cs-check",
5763
"@test"
5864
],
59-
"upload-coverage": "coveralls -v",
60-
"cs-check": "php-cs-fixer --version && php-cs-fixer fix -v --diff --dry-run",
61-
"cs-fix": "php-cs-fixer fix -v",
62-
"test": "phpunit",
63-
"test-coverage": "phpunit --coverage-clover clover.xml"
65+
"cs-check": "phpcs",
66+
"cs-fix": "phpcbf",
67+
"test": "phpunit --colors=always",
68+
"test-coverage": "phpunit --colors=always --coverage-clover clover.xml",
69+
"upload-coverage": "coveralls -v"
6470
}
6571
}

0 commit comments

Comments
 (0)