Metrics: add Async Instruments #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
With this commit, async instruments can now be instructed to run callbacks using a provided Context, a wrapper around any struct pointer. This allows to execute methods or fetch data from the Context inside callbacks. Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
kakkoyun
reviewed
Jun 6, 2025
| defer self.lock.unlock(); | ||
|
|
||
| if (self.callbacks) |c| { | ||
| var m = try allocator.alloc(MeasurementsData, c.len); |
There was a problem hiding this comment.
Could this be allocated in stack?
There was a problem hiding this comment.
That would be good, although in order to be on the stack, the array must have compile-time known size.
Since the number of callbacks is known at runtime, we have to allocate on the heap.
We could make the array of callbacks field comptime, but we would have to put un upper bound to it, and do not allow registerCallback to be called at runtime (marking it also as comptime), but that would violate the OTel spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Complete the development of Metrics SDK features by adding the
Observable...instruments to the meter.The instruments are detailed in the OTel spec.
Details
Closes #20
MeasurementsDatawas added some helpers to ease the encapsulation of manipulating data returned by multiple callbacksMeterextended to allow creation of async instrumentsAdditional context
I am not 100% satisfied with the public API shape honestly, as it could lead some confusion on what to do with the returned type from the
meter.createObservableXXXmethods.I'll raise an issue to improve the UX on that.