Skip to content

chore: remove std.debug.print output from tests #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inge4pres opened this issue May 8, 2025 · 3 comments
Open

chore: remove std.debug.print output from tests #44

inge4pres opened this issue May 8, 2025 · 3 comments
Assignees
Labels

Comments

@inge4pres
Copy link
Collaborator

Describe the current state

When running zig build test the output contains error message from tests that are expected to fail.
The output can be confusing and it would be best if it's be isolated.

Describe the desired state

The tests output is flused into a temporary memory buffer.
It is not strictly necessary that it is usable for inspection, it would be a nice to have though, in case some tests want to assert on error messages.

Proposed solution

Replace std.debug.print calls with std.log and find a way to direct the log output to a memory buffer, ideally per-test.

@inge4pres inge4pres added the good first issue Good for newcomers label May 17, 2025
@klaus82
Copy link
Collaborator

klaus82 commented May 19, 2025

Hi @inge4pres can I start from this?

@inge4pres
Copy link
Collaborator Author

@klaus82 seems like the perfect one to get started!
Thanks 🙏🏼

@inge4pres
Copy link
Collaborator Author

inge4pres commented May 20, 2025

There are some in-flight PRs that are still adding some std.debug.print calls, they're all on me though so I'll make sure to replace with whatever you come up to replace before merging, or update after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants