httpdebug feedback #7
Merged
+76
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-littlefarmer
approved these changes
Jun 5, 2025
|
|
||
| type ctxKey struct{} | ||
|
|
||
| func isDebugModeEnabled(ctx context.Context) bool { |
There was a problem hiding this comment.
Keep it exported, so we can use it anywhere we want.
Suggested change
| func isDebugModeEnabled(ctx context.Context) bool { | |
| func IsDebugModeEnabled(ctx context.Context) bool { |
|
|
||
| // Header represents a special header that enables debug mode. | ||
| type Header struct { | ||
| Key string `toml:"key"` |
There was a problem hiding this comment.
This is more straigtforward.
Suggested change
| Key string `toml:"key"` | |
| Header string `toml:"header"` |
Value is beter then password 👍
There was a problem hiding this comment.
They call it Key+Value in Go http.Header methods:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.