Skip to content

Dev2 env #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Dev2 env #789

wants to merge 7 commits into from

Conversation

Agusx1211
Copy link
Member

  • Centralize constants
  • Add dev2 context
  • Add dev2 extensions

Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Latest Commit Updated (UTC)
❌ Deployment failed 3d7cc82 Jun 06 2025, 04:54 PM

@Agusx1211 Agusx1211 requested a review from Copilot June 6, 2025 16:56
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes constants and upgrades the environment configuration to support Dev2 by updating contexts and extensions. Key changes include:

  • Updating import and reference of extensions (adding Dev2) across multiple files.
  • Changing ManagerOptionsDefaults to use Dev2 context and extensions.
  • Removing legacy default session manager addresses in favor of centralized configuration.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/wallet/wdk/test/sessions.test.ts Updated import to include Extensions; sessionManagerAddress still uses Dev1.
packages/wallet/wdk/src/sequence/wallets.ts Updated sessions topology configuration with new weight and address reference.
packages/wallet/wdk/src/sequence/sessions.ts Removed default session manager addresses; now references centralized extensions.
packages/wallet/wdk/src/sequence/manager.ts Updated defaults to use Dev2 context and extensions; removed defaultSessionsTopology.
packages/wallet/primitives/src/extensions/index.ts Added sessions property and Dev2 extensions.
packages/wallet/primitives/src/context.ts Updated Dev1 and Dev2 context definitions with new constants.
packages/wallet/primitives/src/constants.ts Removed legacy constants and updated DefaultGuest.
packages/wallet/primitives-cli/src/subcommands/address.ts Updated creation code default reference from Constants to Context.Dev2.
packages/wallet/core/test/session-manager.test.ts Updated many session manager address references to Extensions.Dev1.
packages/wallet/core/src/signers/session-manager.ts Refactored SessionManager options to require explicit options rather than using defaults.
Comments suppressed due to low confidence (3)

packages/wallet/wdk/test/sessions.test.ts:113

  • The PR title and description indicate an upgrade to Dev2, yet this line still references Extensions.Dev1. Consider updating it to Extensions.Dev2.sessions if the intent is to fully transition to Dev2.
sessionManagerAddress: Extensions.Dev1.sessions,

packages/wallet/core/test/session-manager.test.ts:73

  • Several tests continue to reference Extensions.Dev1.sessions, which may be inconsistent with the new Dev2 configuration. Verify if the tests should be updated to use Extensions.Dev2.sessions to align with the updated environment.
topology: { type: 'sapient-signer', address: Extensions.Dev1.sessions, weight: 1n, imageHash },

packages/wallet/core/src/signers/session-manager.ts:33

  • The removal of the DefaultSessionManagerOptions and making options mandatory might affect legacy code relying on defaults. Consider documenting this change explicitly or providing backward compatibility measures if needed.
constructor( readonly wallet: Wallet, options: SessionManagerOptions, ) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant