Skip to content

IBA::contrast_remap() and oiiotool --contrast #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Oct 25, 2018

Allows flexible linear or sigmoidal contrast remapping.

Allows flexible linear or sigmoidal contrast remapping.
@lgritz
Copy link
Collaborator Author

lgritz commented Oct 29, 2018

@marsupial Any opinions?

@marsupial
Copy link
Contributor

Yet to try it out, but liking the curves/ramp and per-channels.
Still into the idea of getting max/min and fitting a range in one call, but maybe the use-case is too specialized, easily added, or I'm reading the docs wrong?

@lgritz
Copy link
Collaborator Author

lgritz commented Oct 29, 2018

Does it have to be in one call (C++/Python)? Or can it just be super easy on one oiiotool command line? Because the latter is straightforward, I just wanted to do that as a separate PR.

@marsupial
Copy link
Contributor

marsupial commented Oct 31, 2018

Agree its a separate topic and can be dealt with after.
Think/prefer it would be programmatic though rather than oiiotool.
I can rebase & tinker with #2035, and if you think it's too specific, just use it from the client

@lgritz lgritz merged commit b611970 into AcademySoftwareFoundation:master Nov 1, 2018
@lgritz lgritz deleted the lg-contrast branch November 1, 2018 06:11
@lgritz lgritz mentioned this pull request Nov 24, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants