Fix broken TIFF with JPEG compression #2117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPEG compression was one of the cases where we fell back on the TIFFRGBAImage interface of libtiff. This worked for some JPEG images, but crashed on others, inside the TIFF library. Never did figure out why. But do we really need to to use the RGBAImage interface? Turns out, no! At least, not if it's still a spectral RGB image. So just using the regular interface for ordinary RGB JPEG-compressed TIFF images is fine, fixes the problem. Also improved an error message while I was in there.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 3, 2019
JPEG compression was one of the cases where we fell back on the TIFFRGBAImage interface of libtiff. This worked for some JPEG images, but crashed on others, inside the TIFF library. Never did figure out why. But do we really need to to use the RGBAImage interface? Turns out, no! At least, not if it's still a spectral RGB image. So just using the regular interface for ordinary RGB JPEG-compressed TIFF images is fine, fixes the problem. Also improved an error message while I was in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JPEG compression was one of the cases where we fell back on the TIFFRGBAImage interface of libtiff. This worked for some JPEG images, but crashed on others, inside the TIFF library. Never did figure out why.
But do we really need to to use the RGBAImage interface? Turns out, no! At least, not if it's still a spectral RGB image.
So just using the regular interface for ordinary RGB JPEG-compressed TIFF images is fine, fixes the problem.
Also improved an error message while I was in there.