Filter selection enhancements #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Main event: add "nuke-lanczos6" as an alias for our "lanczos3" filter. (Nuke names it according to the full width, which makes sense but is different than our more conventional lanczos3 nomenclature. Made the alias to make it more obvious which to choose if you want to exactly replicate what Nuke calls lanczos6.) * Added new flavor of get_filterdesc() that returns a const ref, instead of copying into a parameter by pointer. (In retrospect, I'm not even sure why I did it that way.) * Made `oiiotool --help -v` print the available filters, for handy reference.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 14, 2019
* Main event: add "nuke-lanczos6" as an alias for our "lanczos3" filter. (Nuke names it according to the full width, which makes sense but is different than our more conventional lanczos3 nomenclature. Made the alias to make it more obvious which to choose if you want to exactly replicate what Nuke calls lanczos6.) * Added new flavor of get_filterdesc() that returns a const ref, instead of copying into a parameter by pointer. (In retrospect, I'm not even sure why I did it that way.) * Made `oiiotool --help -v` print the available filters, for handy reference.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 14, 2019
* Main event: add "nuke-lanczos6" as an alias for our "lanczos3" filter. (Nuke names it according to the full width, which makes sense but is different than our more conventional lanczos3 nomenclature. Made the alias to make it more obvious which to choose if you want to exactly replicate what Nuke calls lanczos6.) * Added new flavor of get_filterdesc() that returns a const ref, instead of copying into a parameter by pointer. (In retrospect, I'm not even sure why I did it that way.) * Made `oiiotool --help -v` print the available filters, for handy reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main event: add "nuke-lanczos6" as an alias for our "lanczos3" filter.
(Nuke names it according to the full width, which makes sense but is
different than our more conventional lanczos3 nomenclature. Made the
alias to make it more obvious which to choose if you want to exactly
replicate what Nuke calls lanczos6.)
Added new flavor of get_filterdesc() that returns a const ref,
instead of copying into a parameter by pointer. (In retrospect, I'm
not even sure why I did it that way.)
Made
oiiotool --help -vprint the available filters, for handyreference.