Bug fix in deep image compare when pixels had different # of samples #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
The IBA::compare for deep images A and B would loop over pixels in the union of A's and B's ROIs (so far, so good), then for each pixel would loop from 0 to A's number of samples in that pixel. Oops! That means that if A had fewer samples than B (or if A had no samples but B had samples) in that pixel, it would not notice that the images were different.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 5, 2019
…cademySoftwareFoundation#2381) The IBA::compare for deep images A and B would loop over pixels in the union of A's and B's ROIs (so far, so good), then for each pixel would loop from 0 to A's number of samples in that pixel. Oops! That means that if A had fewer samples than B (or if A had no samples but B had samples) in that pixel, it would not notice that the images were different.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 6, 2019
…cademySoftwareFoundation#2381) The IBA::compare for deep images A and B would loop over pixels in the union of A's and B's ROIs (so far, so good), then for each pixel would loop from 0 to A's number of samples in that pixel. Oops! That means that if A had fewer samples than B (or if A had no samples but B had samples) in that pixel, it would not notice that the images were different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBA::compare for deep images A and B would loop over pixels in the
union of A's and B's ROIs (so far, so good), then for each pixel would
loop from 0 to A's number of samples in that pixel. Oops! That means
that if A had fewer samples than B (or if A had no samples but B had
samples) in that pixel, it would not notice that the images were
different.