Python: implement ROI.copy() #3253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow I never implemented a copy() method for ROI, which of course is super useful if you want to make an actual copy of an ROI and modify the copy. I also realized that ImageSpec.copy() unnecessarily/incorrectly set return_value_policy to reference_internal, but actually it should be a real copy, which it has to be anyway because the implementation creates a separate copy.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jan 17, 2022
Somehow I never implemented a copy() method for ROI, which of course is super useful if you want to make an actual copy of an ROI and modify the copy. I also realized that ImageSpec.copy() unnecessarily/incorrectly set return_value_policy to reference_internal, but actually it should be a real copy, which it has to be anyway because the implementation creates a separate copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow we never implemented a copy() method for ROI, which of course is
super useful if you want to make an actual copy of an ROI and modify
the copy.
I also realized that ImageSpec.copy() unnecessarily/incorrectly set
return_value_policy to reference_internal, but actually it should be a
real copy, which it has to be anyway because the implementation
creates a separate copy.