oiiotool protect against OpenEXR thread deadlock on Windows #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by SideFX: explicitly shut down the OpenEXR thread pool before exiting oiiotool, because sometimes on Windows it seems to hang otherwise. A better solution is probably possible on the OpenEXR side, but I don't know what it would be. (And in any case, we'd still need to do this be be well behaved when using OpenEXR versions earlier than where a fix might land.) Solution tracked down by Edward Lam.
|
Upon seeing this, my first thought was "Didn't @debaetsd commit some fixes that touched this about a year are so ago when working on Windows CI fixes?" There were other fixes (and #2038 even earlier), but it turns out #2797 and AcademySoftwareFoundation/openexr#890 are still open.
Perhaps its time to take a second at the proposed solution in that OpenEXR thread? |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 6, 2022
…oftwareFoundation#3582) Suggested by SideFX: explicitly shut down the OpenEXR thread pool before exiting oiiotool, because sometimes on Windows it seems to hang otherwise. A better solution is probably possible on the OpenEXR side, but I don't know what it would be. (And in any case, we'd still need to do this be be well behaved when using OpenEXR versions earlier than where a fix might land.) Solution tracked down by Edward Lam.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 6, 2022
…oftwareFoundation#3582) Suggested by SideFX: explicitly shut down the OpenEXR thread pool before exiting oiiotool, because sometimes on Windows it seems to hang otherwise. A better solution is probably possible on the OpenEXR side, but I don't know what it would be. (And in any case, we'd still need to do this be be well behaved when using OpenEXR versions earlier than where a fix might land.) Solution tracked down by Edward Lam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by SideFX: explicitly shut down the OpenEXR thread pool before exiting oiiotool, because sometimes on Windows it seems to hang otherwise. A better solution is probably possible on the OpenEXR side, but I don't know what it would be. (And in any case, we'd still need to do this be be well behaved when using OpenEXR versions earlier than where a fix might land.)
Solution tracked down by Edward Lam.