Fix unresolved external symbol for MSVS 2017 (#3762) #3763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on#3762) If char16_t is used as template argument, this leads to an unresolved symbol for MSVS 2017. Use int16_t instead of char16_t in this case
lgritz
reviewed
Feb 2, 2023
lgritz
approved these changes
Feb 2, 2023
|
LGTM, thanks for the fix! Do you need a tagged release right away? |
|
@lgritz If that is possible, that would be great! But if it's too much effort, I can also just include the patch in the Conan package |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 4, 2023
…on#3762) (AcademySoftwareFoundation#3763) If char16_t is used as template argument, this leads to an unresolved symbol for MSVS 2017. Use int16_t instead of char16_t in this case
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If char16_t is used as template argument, this leads to an unresolved symbol for MSVS 2017. Use int16_t instead of char16_t in this case.
Fixes #3762
Checklist:
If this is more extensive than a small change to existing code, IThis is just a small changehave previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
I have updated the documentation, if applicable.Not applicable.I have ensured that the change is tested somewhere in the testsuiteNot applicable.(adding new test cases if necessary).