Skip to content

Initialize OpenEXROutput::m_levelmode() in init(). #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jreichel-nvidia
Copy link
Contributor

Avoids conditional jump on uninitialised values in close(). Not sure whether ONE_LEVEL is the best value here ...

Description

Without that fix, valgrind reports a conditional jump on uninitialised values on code like

auto out = OIIO::ImageOutput::create( "exr");

Checklist:

  • I have read the contribution guidelines.
  • If this is more extensive than a small change to existing code, I
    have previously submitted a Contributor License Agreement
    (individual, and if there is any way my
    employers might think my programming belongs to them, then also
    corporate).
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

Avoids conditional jump on uninitialised values in close().
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit a8b93f0 into AcademySoftwareFoundation:master Feb 4, 2023
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Feb 4, 2023
…undation#3764)

Avoids conditional jump on uninitialised values in close().

Co-authored-by: Joachim Reichel <[email protected]>
lgritz pushed a commit to lgritz/OpenImageIO that referenced this pull request Feb 5, 2023
…undation#3764)

Avoids conditional jump on uninitialised values in close().

Co-authored-by: Joachim Reichel <[email protected]>
@jreichel-nvidia jreichel-nvidia deleted the fix_openexr_conditional_jump branch July 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants