Skip to content

Only check REST arguments if the file does not exist #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Only check REST arguments if the file does not exist #4085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/libOpenImageIO/imageioplugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,10 +649,14 @@ ImageInput::create(string_view filename, bool do_open, const ImageSpec* config,
std::unique_ptr<ImageInput> in;
std::map<std::string, std::string> args;
std::string filename_stripped;
if (!Strutil::get_rest_arguments(filename, filename_stripped, args)) {
OIIO::pvt::errorfmt(
"ImageInput::create() called with malformed filename");
return in;

// Only check REST arguments if the file does not exist
if (!Filesystem::exists(filename)) {
if (!Strutil::get_rest_arguments(filename, filename_stripped, args)) {
OIIO::pvt::errorfmt(
"ImageInput::create() called with malformed filename");
return in;
}
}

if (filename_stripped.empty())
Expand Down