ci: Fix wheel building on Mac #4668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to work until a few days ago. Then it stopped. I think that GitHub changed the Mac runner configuration to not already have ninja installed, so we need to instruct it to use regular makefiles and not ninja files. Along for the ride: If ONLY the wheel making workflow changes, there's no need to rerun the regular CI, docs, or analysis workflows. Signed-off-by: Larry Gritz <[email protected]>
|
Interesting. No objections at all to the stuff that's come along for the ride. I would like to dive deeper into whatever's causing the problems with ninja, because ninja should be coming from scikit_build_core (i.e. as a dependency needed for python-based builds, same as with cmake itself). This could be indicative of a change introduced by a newer version of scikit_build_core itself, in which case, we might be better served by more tightly constraining the version requirement upper bound. (Still, no problem with changing the generator to "Unix Makefiles", that's a clever workaround) |
|
Maybe it was scikit_build_core? In any case, it only failed on Mac Intel. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 16, 2025
This used to work until a few days ago. Then it stopped. I think that GitHub changed the Mac runner configuration in some way that broke it, now it's complaining about not being able to find ninja, so easily fixed by instructing it to generate regular makefiles instead. Along for the ride: If ONLY the wheel making workflow changes, there's no need to rerun the regular CI, docs, or analysis workflows. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
that referenced
this pull request
Mar 22, 2025
The Intel Macs had this problem last week and #4668 fixed it. Now suddenly the ARM Macs had it this week. Seems to be something changing on the skbuild side. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 22, 2025
…ndation#4668) (AcademySoftwareFoundation#4675) The Intel Macs had this problem last week and AcademySoftwareFoundation#4668 fixed it. Now suddenly the ARM Macs had it this week. Seems to be something changing on the skbuild side. Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
This used to work until a few days ago. Then it stopped. I think that GitHub changed the Mac runner configuration in some way that broke it, now it's complaining about not being able to find ninja, so easily fixed by instructing it to generate regular makefiles instead. Along for the ride: If ONLY the wheel making workflow changes, there's no need to rerun the regular CI, docs, or analysis workflows. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…ndation#4668) (AcademySoftwareFoundation#4675) The Intel Macs had this problem last week and AcademySoftwareFoundation#4668 fixed it. Now suddenly the ARM Macs had it this week. Seems to be something changing on the skbuild side. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
This used to work until a few days ago. Then it stopped. I think that GitHub changed the Mac runner configuration in some way that broke it, now it's complaining about not being able to find ninja, so easily fixed by instructing it to generate regular makefiles instead. Along for the ride: If ONLY the wheel making workflow changes, there's no need to rerun the regular CI, docs, or analysis workflows. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…ndation#4668) (AcademySoftwareFoundation#4675) The Intel Macs had this problem last week and AcademySoftwareFoundation#4668 fixed it. Now suddenly the ARM Macs had it this week. Seems to be something changing on the skbuild side. Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to work until a few days ago. Then it stopped. I think that GitHub changed the Mac runner configuration in some way that broke it, now it's complaining about not being able to find ninja, so easily fixed by instructing it to generate regular makefiles instead.
Along for the ride: If ONLY the wheel making workflow changes, there's no need to rerun the regular CI, docs, or analysis workflows.