Docs: correct the type for BMP x/y density #4695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are read & written as integers and don't work unless they are accessed using int accessors. Signed-off-by: Campbell Barton <[email protected]>
ideasman42
force-pushed
the
pr-bmp-density-correction
branch
from
5469034 to
b611767
Compare
lgritz
approved these changes
Apr 8, 2025
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 12, 2025
…#4695) These values are read & written as integers and don't work unless they are accessed using int accessors. m_dib_header.hres = m_spec.get_int_attribute("XResolution"); Correct documentation. BMP uses integer access: - `./src/bmp.imageio/bmpinput.cpp:`, `m_spec.attribute("XResolution", (int)m_dib_header.hres);` - `./src/bmp.imageio/bmpoutput.cpp`, `m_dib_header.hres = m_spec.get_int_attribute("XResolution");` Signed-off-by: Campbell Barton <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…#4695) These values are read & written as integers and don't work unless they are accessed using int accessors. m_dib_header.hres = m_spec.get_int_attribute("XResolution"); Correct documentation. BMP uses integer access: - `./src/bmp.imageio/bmpinput.cpp:`, `m_spec.attribute("XResolution", (int)m_dib_header.hres);` - `./src/bmp.imageio/bmpoutput.cpp`, `m_dib_header.hres = m_spec.get_int_attribute("XResolution");` Signed-off-by: Campbell Barton <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…#4695) These values are read & written as integers and don't work unless they are accessed using int accessors. m_dib_header.hres = m_spec.get_int_attribute("XResolution"); Correct documentation. BMP uses integer access: - `./src/bmp.imageio/bmpinput.cpp:`, `m_spec.attribute("XResolution", (int)m_dib_header.hres);` - `./src/bmp.imageio/bmpoutput.cpp`, `m_dib_header.hres = m_spec.get_int_attribute("XResolution");` Signed-off-by: Campbell Barton <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values are read & written as integers
and don't work unless they are accessed using int accessors.
m_dib_header.hres = m_spec.get_int_attribute("XResolution");
Description
Correct documentation.
BMP uses integer access:
./src/bmp.imageio/bmpinput.cpp:,m_spec.attribute("XResolution", (int)m_dib_header.hres);./src/bmp.imageio/bmpoutput.cpp,m_dib_header.hres = m_spec.get_int_attribute("XResolution");