Skip to content

build: fix fmt throwing behavior warnings #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Apr 29, 2025

Certain version combinations of fmt and gcc were warning, and it all boiled down to the knots we tied ourselves into to replace the function fmt uses instead of throwing exceptions, when they are disabled. I can't seem to find any harm in letting it do its default thing, so simplify our side to silence the warnings.

Certain version combinations of fmt and gcc were warning, and it
all boiled down to the knots we tied ourselves into to replace the
function fmt uses instead of throwing exceptions, when they are
disabled. I can't seem to find any harm in letting it do its default
thing, so simplify our side to silence the warnings.

Signed-off-by: Larry Gritz <[email protected]>
@lgritz lgritz changed the title int: fix fmt throwing behavior warnings build: fix fmt throwing behavior warnings Apr 29, 2025
@lgritz lgritz added the build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. label Apr 30, 2025
@lgritz
Copy link
Collaborator Author

lgritz commented May 2, 2025

This fixes some build problems on certain toolchain version combinations. Anybody have concerns?

@lgritz
Copy link
Collaborator Author

lgritz commented May 7, 2025

No objections for more than a week -> merging

@lgritz lgritz merged commit 569c118 into AcademySoftwareFoundation:main May 7, 2025
28 checks passed
@lgritz lgritz deleted the lg-fmt branch May 7, 2025 17:11
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request May 7, 2025
…4730)

Certain version combinations of fmt and gcc were warning, and it all
boiled down to the knots we tied ourselves into to replace the function
fmt uses instead of throwing exceptions, when they are disabled. I can't
seem to find any harm in letting it do its default thing, so simplify
our side to silence the warnings.

Signed-off-by: Larry Gritz <[email protected]>
scott-wilson pushed a commit to scott-wilson/OpenImageIO that referenced this pull request May 17, 2025
…4730)

Certain version combinations of fmt and gcc were warning, and it all
boiled down to the knots we tied ourselves into to replace the function
fmt uses instead of throwing exceptions, when they are disabled. I can't
seem to find any harm in letting it do its default thing, so simplify
our side to silence the warnings.

Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Scott Wilson <[email protected]>
scott-wilson pushed a commit to scott-wilson/OpenImageIO that referenced this pull request May 18, 2025
…4730)

Certain version combinations of fmt and gcc were warning, and it all
boiled down to the knots we tied ourselves into to replace the function
fmt uses instead of throwing exceptions, when they are disabled. I can't
seem to find any harm in letting it do its default thing, so simplify
our side to silence the warnings.

Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Scott Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant