feat: Consumer support for scrolling and clipping children #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcampbell
force-pushed
the
consumer-scroll
branch
from
0b1d72b to
8cbba5a
Compare
DataTriny
requested changes
Jun 20, 2025
consumer/src/filters.rs
Outdated
| @@ -223,4 +272,133 @@ mod tests { | |||
| common_filter(&tree.state().node_by_id(NodeId(1)).unwrap()) | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn clipped_children() { | |||
There was a problem hiding this comment.
I feel like this test tests too many things at once, making it harder to understand if it fail in the future. Could you please try to split it so that each function contain less assertions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the scrolling and
clips_childrenon the consumerNodestruct. It also adds a new rule to the common filter to exclude clipped children, except for one clipped child at either end of a list (so that child can be scrolled into view).