Skip to content

nbdev_clean: Convert nb to AttrDict before processing #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

xl0
Copy link
Contributor

@xl0 xl0 commented Feb 9, 2023

Otherwise, the change introduced by e47162f does nothing.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xl0
Copy link
Contributor Author

xl0 commented Feb 9, 2023

I'm not sure what's up with the single failed CI test.

@xl0
Copy link
Contributor Author

xl0 commented Feb 9, 2023

@jph00 The failed CI is caused by an unrelated Quarto issue: quarto-dev/quarto-cli#4295. I'm seeing the same on my host system with clean nbdev too.

@jph00 jph00 merged commit 3acb976 into AnswerDotAI:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants